search

wolf4ood / gremlin-rs

Gremlin Rust
Apache License 2.0
106 stars 29 forks source link

Generic Error Message Not Included In Message #203

Closed criminosis closed 3 months ago

criminosis commented 3 months ago

@wolf4ood would it be possible to include the wrapped error message in the thiserror annotation for the Generic Error?

I think it'd just need to be changed to something like:

#[error("data store disconnected: {0}")]
Generic(String),

As it stands I keep having this error occur and data store disconnected gets logged, but I don't have any context as to why.

Sort of tangental to the issue but is it expected for when this error occurs to drop the client and manually re-create it? Currently I just keep retrying the same traversal, but once whatever error this is starts to happen it seems to keep failing in my retry loop until I restart the program.

wolf4ood commented 3 months ago

Hi @criminosis sure, can you provide a PR for this?

criminosis commented 3 months ago

@wolf4ood happily. Pushed it up https://github.com/wolf4ood/gremlin-rs/pull/204

If you wouldn't mind cutting a release once it's merged I'd appreciate it!

wolf4ood commented 3 months ago

Sure i can do the release :)

criminosis commented 3 months ago

Thank you!

wolf4ood commented 3 months ago

@criminosis released :)

criminosis commented 3 months ago

@wolf4ood Thanks!