search

wolf4ood / gremlin-rs

Gremlin Rust
Apache License 2.0
106 stars 30 forks source link

Expose connection pool's get timeout via ConnectionOptionsBuilder #212

Closed criminosis closed 4 months ago

criminosis commented 4 months ago

I was periodically encountering my applications effectively locking up because of Errors stating Async pool timeout . In my use case I'd rather just wait indefinitely for a connection to be available throughout my application. Prior to this PR gremlin-rs was relying on the default pool connection timeout of 30 seconds, coincidentally the same for both the sync pool (r2d2) and the async pool (mobc) providers.

This PR will allow users of the library to modify the timeout, and possibly, for the async pool, opt out of a timeout all together.

@wolf4ood jumped to a PR, but happy to open an issue if you'd like to talk & refine the idea further. If it looks good to you as is mind cutting another release once it's merged?

criminosis commented 4 months ago

@wolf4ood just checking in, anything you'd like changed?

wolf4ood commented 4 months ago

@criminosis released

criminosis commented 4 months ago

No worries, thank you @wolf4ood!