search

wolfSSL / wolfBoot

wolfBoot is a portable, OS-agnostic, secure bootloader for microcontrollers, supporting firmware authentication and firmware update mechanisms.
https://www.wolfssl.com
GNU General Public License v3.0
347 stars 98 forks source link

Use bash from env for better portability #383

Closed Luz closed 11 months ago

Luz commented 11 months ago

Hi According to Stackoverflow it looks like the portability of the scripts could be improved by having this new style for the bash shebang.

danielinux commented 11 months ago

Hi @Luz, May I ask if there is any specific reason for this? The answers on the thread you linked don't seem to agree on a definitive portable method, and the current shebangs seem to work on all systems we tested. Are you trying to run these script in a specific OS? If so, what issue did you encounter?

Thanks,

Luz commented 11 months ago

Well scripts are not executable for me, as I have no /bin/bash :( But I can also easily fix it on my system (nixos), would be no problem :) Feel free to close, if you prefer the current style :)

danielinux commented 11 months ago

Thanks for the explanation. We have decided to keep our current #! for now, to avoid breaking compatibility for existing users, but we may reconsider this in the future.