wolfSSL / wolfEngine

wolfCrypt and wolfCrypt FIPS engine for OpenSSL
https://www.wolfssl.com
GNU General Public License v3.0
23 stars 26 forks source link

Adding FIPS 140-3 Windows build support #195

Closed tim-weller-wolfssl closed 1 year ago

tim-weller-wolfssl commented 2 years ago

Tested in Windows 11 environment using Visual Studio 2022.

JacobBarthelmeh commented 2 years ago
Severity    Code    Description Project File    Line    Suppression State
Error   MSB3073 The command "copy /Y "D:\work\wolfengine\windows\..\..\openssl\*.dll" "D:\work\wolfengine\windows\Debug FIPS 140-3\Win32\"
copy /Y "D:\work\wolfengine\windows\..\..\wolfssl\IDE\WIN10\DLL Debug\Win32\*.dll" "D:\work\wolfengine\windows\Debug FIPS 140-3\Win32\"
:VCEnd" exited with code 1. test    C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets   157 

The files do seem to exist

PS D:\work\openssl> ls *.dll

    Directory: D:\work\openssl

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----         9/15/2022   2:34 PM        2255872 libcrypto-1_1.dll
-a----         9/15/2022   2:34 PM         538624 libssl-1_1.dll

Edit: Rebuilding wolfSSL as "DLL Debug" passed post command copy, before as just "Debug" the wolfssl.dll file did not exist. This got to the point of doing a run time test which returned one failure:


## FAIL: 37: test_dh_key_gen_multithreaded
###### TESTSUITE FAILED

Do I need to update some settings for this one to pass?

tim-weller-wolfssl commented 2 years ago

@JacobBarthelmeh, thank-you for the feedback! I have missed some testing permutations. Let me revisit testing, and update the PR accordingly.

haydenroche5 commented 1 year ago

@tim-weller-wolfssl you can assign me back to this when you're ready for another round of review.

haydenroche5 commented 1 year ago

@tim-weller-wolfssl It looks like your latest push has a merge commit in it. Please rebase your local commits onto upstream master and push that way. Your commits should be linear on top of master. Ping me if you need further assistance.

tim-weller-wolfssl commented 1 year ago

It was determined that initially, at least, FIPS 140-3 on Windows will only be buildable as a DLL. Testing of the added support involved building and running the wolfEngine test in the following configurations in Windows (11), for both x64 and Win32 (x86):