wolfSSL / wolfMQTT

wolfMQTT is a small, fast, portable MQTT client implementation, including support for TLS 1.3.
https://www.wolfssl.com
GNU General Public License v2.0
518 stars 156 forks source link

Fix some Helgrind thread errors with enable-tls, and enable-curl. #396

Closed philljj closed 4 months ago

philljj commented 5 months ago

Fixes a subset of thread errors from PR https://github.com/wolfSSL/wolfMQTT/pull/395.

Fix some Helgrind thread errors around simultaneous reads and writes from different threads:

This passes whereas PR https://github.com/wolfSSL/wolfMQTT/pull/395 fails. Apparently the extra locking around SSL struct makes the multithreading CI tests unstable, though it fixes threading errors.

Note: ultimately tested with helgrind and drd:

dgarske commented 4 months ago

Jordan, I am assigning this over to @embhorn to review.