search

wolfSSL / wolfMQTT

wolfMQTT is a small, fast, portable MQTT client implementation, including support for TLS 1.3.
https://www.wolfssl.com
GNU General Public License v2.0
529 stars 158 forks source link

Allow configuration using cmake without WolfSSL #410

Open chazste opened 6 days ago

chazste commented 6 days ago

Running cmake without having wolfSSL available via one of four (I think) methods just fails. However when configuring with ./configure (autotools) passing --enable-tls=no works fine.

Proposal would be to move the package search code inside the block protected by WOLFMQTT_TLS

I will open a PR shortly.

embhorn commented 4 days ago

Hello @chazste

Thanks for the suggestion. Could you tell us a bit about your project using wolfMQTT?

This sounds like a good change for the cmake build. We don't typically accept small changes, and we require a signed contributor agreement for all code submissions. Do you think you'll be making additional code changes? Otherwise I can open a new PR that accommodates your request.

Thanks, @embhorn - wolfSSL Support

chazste commented 3 days ago

Hello Eric,    I think it makes the most sense for you to go ahead and open a new PR. Thank you very much for the offer.

-charles On Sunday, November 17, 2024 at 05:18:52 PM CST, Eric Blankenhorn @.***> wrote:

Hello @chazste

Thanks for the suggestion. Could you tell us a bit about your project using wolfMQTT?

This sounds like a good change for the cmake build. We don't typically accept small changes, and we require a signed contributor agreement for all code submissions. Do you think you'll be making additional code changes? Otherwise I can open a new PR that accommodates your request.

Thanks, @embhorn - wolfSSL Support

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>