wolfSSL / wolfTPM

wolfTPM is a highly portable TPM 2.0 library, designed for embedded use.
https://www.wolfssl.com
GNU General Public License v2.0
244 stars 60 forks source link

Initial cmake build file and fixes for Windows #202

Closed elms closed 2 years ago

elms commented 2 years ago

Add cmake support and Windows improvements

elms commented 2 years ago

@haydenroche5 and @dgarske This is still a work in progress, but only expect minor fixes and clean as I test a little more on Windows. Any early feedback would be appreciated.

elms commented 2 years ago

The compiled applications were put into the build dir, but did you consider putting the existing locations in examples directories?

I know we do this for wolfssl, but for cmake and windows in general I think it's considered poor practice.

haydenroche5 commented 2 years ago

The compiled applications were put into the build dir, but did you consider putting the existing locations in examples directories?

I know we do this for wolfssl, but for cmake and windows in general I think it's considered poor practice.

Agree with Jeff. I did it that way in wolfSSL to make it mirror autotools as much as possible, but generally speaking about CMake, all build artifacts should stay in the build directory.

elms commented 2 years ago

I was failing to unload the handles. The error in unseal was when no additional handles were available. Thanks for catching that.