wolfSSL / wolfTPM

wolfTPM is a highly portable TPM 2.0 library, designed for embedded use.
https://www.wolfssl.com
GNU General Public License v2.0
244 stars 60 forks source link

HAL refactor and added Microchip Harmony SPI HAL support #251

Closed dgarske closed 1 year ago

dgarske commented 1 year ago
jpbland1 commented 1 year ago

I tried to configure with ./configure --enable-hal and when I ran make I got

john@john-XPS-9320:~/Documents/wolfTPM$ make
make -j17  all-am
make[1]: Entering directory '/home/john/Documents/wolfTPM'
(CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash '/home/john/Documents/wolfTPM/build-aux/missing' autoheader)
  CC       hal/src_libwolftpm_la-tpm_io.lo
  CC       hal/src_libwolftpm_la-tpm_io_atmel.lo
  CC       hal/src_libwolftpm_la-tpm_io_barebox.lo
  CC       hal/src_libwolftpm_la-tpm_io_linux.lo
  CC       hal/src_libwolftpm_la-tpm_io_infineon.lo
  CC       hal/src_libwolftpm_la-tpm_io_st.lo
  CC       hal/src_libwolftpm_la-tpm_io_microchip.lo
  CC       hal/src_libwolftpm_la-tpm_io_qnx.lo
  CC       hal/src_libwolftpm_la-tpm_io_xilinx.lo
rm -f src/stamp-h1
touch src/config.h.in
cd . && /bin/bash ./config.status src/config.h
hal/tpm_io.c:50:10: fatal error: examples/tpm_io_linux.c: No such file or directory
   50 | #include "examples/tpm_io_linux.c"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:2073: hal/src_libwolftpm_la-tpm_io.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
config.status: creating src/config.h
make[1]: Leaving directory '/home/john/Documents/wolfTPM'
make: *** [Makefile:1406: all] Error 2

I think it needs to be #include "tpm_io_linux.c" since it's been moved to the same hal directory

dgarske commented 1 year ago

I tried to configure with ./configure --enable-hal and when I ran make I got

john@john-XPS-9320:~/Documents/wolfTPM$ make
make -j17  all-am
make[1]: Entering directory '/home/john/Documents/wolfTPM'
(CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash '/home/john/Documents/wolfTPM/build-aux/missing' autoheader)
  CC       hal/src_libwolftpm_la-tpm_io.lo
  CC       hal/src_libwolftpm_la-tpm_io_atmel.lo
  CC       hal/src_libwolftpm_la-tpm_io_barebox.lo
  CC       hal/src_libwolftpm_la-tpm_io_linux.lo
  CC       hal/src_libwolftpm_la-tpm_io_infineon.lo
  CC       hal/src_libwolftpm_la-tpm_io_st.lo
  CC       hal/src_libwolftpm_la-tpm_io_microchip.lo
  CC       hal/src_libwolftpm_la-tpm_io_qnx.lo
  CC       hal/src_libwolftpm_la-tpm_io_xilinx.lo
rm -f src/stamp-h1
touch src/config.h.in
cd . && /bin/bash ./config.status src/config.h
hal/tpm_io.c:50:10: fatal error: examples/tpm_io_linux.c: No such file or directory
   50 | #include "examples/tpm_io_linux.c"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:2073: hal/src_libwolftpm_la-tpm_io.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
config.status: creating src/config.h
make[1]: Leaving directory '/home/john/Documents/wolfTPM'
make: *** [Makefile:1406: all] Error 2

I think it needs to be #include "tpm_io_linux.c" since it's been moved to the same hal directory

Thanks John B. Fixes pushed. I had previously installed those examples into /usr/local so I wasn't catching them! Reminds me that we need to add some GitHub actions... I've put that on my list for a future PR.