search

wolfSSL / wolfssh

wolfSSH is a small, fast, portable SSH implementation, including support for SCP and SFTP.
https://www.wolfssl.com
371 stars 87 forks source link

WS_SELECT_RECV_READY undefined #137

Closed Vaibhav1587 closed 5 years ago

Vaibhav1587 commented 5 years ago

Inside *`NonBlockSSH_connect(WOLFSSH ssh)`**

Below values are undefined,

WS_SELECT_RECV_READY
WS_SELECT_ERROR_READY
WS_SELECT_TIMEOUT

Which files contains the definition?

ejohnstown commented 5 years ago

Those constants are defined in wolfssh/test.h. They are used for the select() calls in the example tools.

Vaibhav1587 commented 5 years ago

I'm trying to write my own client.c For now skipped the above code and just running upto connect the server,

getting following error,

3>main.c
3>d:\project\keil_workspace\wolfssl\examples\client\client.h(27): error C2061: syntax error: identifier 'client_test'
3>d:\project\keil_workspace\wolfssl\examples\client\client.h(27): error C2059: syntax error: ';'
3>d:\project\keil_workspace\wolfssl\examples\client\client.h(27): error C2059: syntax error: '<parameter-list>'

It showing error in the **client.h** @ **THREAD_RETURN WOLFSSH_THREAD client_test(void* args);** I have included client.h in my file

ejohnstown commented 5 years ago

In your file main.c, are you including the files:

#include <wolfssh/ssh.h>
#include <wolfssh/test.h>
#include "examples/client/client.h"

Your compile might not like the THREAD_RETURN or WOLFSSH_THREAD labels. For the most part WOLFSSH_THREAD is nothing, but in the Windows case is __stdcall. THREAD_RETURN is OS specific.

ejohnstown commented 5 years ago

Which RTOS are you using?

Vaibhav1587 commented 5 years ago

Now I'm trying to build it on WIN 10.

Then will try for the device(FreeRTOS). Need to get it working first.

Vaibhav1587 commented 5 years ago

Win 10 with Visual Studio 2017

My main : 

#include <stdio.h>

#define WOLFSSL_USER_SETTINGS
#define WOLFSSH_TEST_CLIENT
#include "wolfssh/ssh.h"
#include "wolfssh/test.h"
#include "D:/Project/keil_workspace/wolfssh/examples/client/client.h"
const char testString[] = "Hello, wolfSSH!";

static int SetEcho(int on)
{
#if !defined(USE_WINDOWS_API) && !defined(MICROCHIP_PIC32)
    static int echoInit = 0;
    static struct termios originalTerm;
    if (!echoInit) {
        if (tcgetattr(STDIN_FILENO, &originalTerm) != 0) {
            printf("Couldn't get the original terminal settings.\n");
            return -1;
        }
        echoInit = 1;
    }
    if (on) {
        if (tcsetattr(STDIN_FILENO, TCSANOW, &originalTerm) != 0) {
            printf("Couldn't restore the terminal settings.\n");
            return -1;
        }
    }
    else {
        struct termios newTerm;
        memcpy(&newTerm, &originalTerm, sizeof(struct termios));

        newTerm.c_lflag &= ~ECHO;
        newTerm.c_lflag |= (ICANON | ECHONL);

        if (tcsetattr(STDIN_FILENO, TCSANOW, &newTerm) != 0) {
            printf("Couldn't turn off echo.\n");
            return -1;
        }
    }
#else
    static int echoInit = 0;
    static DWORD originalTerm;
    HANDLE stdinHandle = GetStdHandle(STD_INPUT_HANDLE);
    if (!echoInit) {
        if (GetConsoleMode(stdinHandle, &originalTerm) == 0) {
            printf("Couldn't get the original terminal settings.\n");
            return -1;
        }
        echoInit = 1;
    }
    if (on) {
        if (SetConsoleMode(stdinHandle, originalTerm) == 0) {
            printf("Couldn't restore the terminal settings.\n");
            return -1;
        }
    }
    else {
        DWORD newTerm = originalTerm;

        newTerm &= ~ENABLE_ECHO_INPUT;

        if (SetConsoleMode(stdinHandle, newTerm) == 0) {
            printf("Couldn't turn off echo.\n");
            return -1;
        }
    }
#endif

    return 0;
}
byte userPassword[256];

static int wsUserAuth(byte authType,
    WS_UserAuthData* authData,
    void* ctx)
{
    const char* defaultPassword = (const char*)ctx;
    word32 passwordSz = 0;
    int ret = WOLFSSH_USERAUTH_SUCCESS;

    (void)authType;
    if (defaultPassword != NULL) {
        passwordSz = (word32)strlen(defaultPassword);
        memcpy(userPassword, defaultPassword, passwordSz);
    }
    else {
        printf("Password: ");
        SetEcho(0);
        if (fgets((char*)userPassword, sizeof(userPassword), stdin) == NULL) {
            printf("Getting password failed.\n");
            ret = WOLFSSH_USERAUTH_FAILURE;
        }
        else {
            char* c = strpbrk((char*)userPassword, "\r\n");;
            if (c != NULL)
                *c = '\0';
        }
        passwordSz = (word32)strlen((const char*)userPassword);
        SetEcho(1);
#ifdef USE_WINDOWS_API
        printf("\r\n");
#endif
    }

    if (ret == WOLFSSH_USERAUTH_SUCCESS) {
        authData->sf.password.password = userPassword;
        authData->sf.password.passwordSz = passwordSz;
    }

    return ret;
}

THREAD_RETURN WOLFSSH_THREAD client_test(void* args) {
    WOLFSSH_CTX* ctx = NULL;
    WOLFSSH* ssh = NULL;
    SOCKET_T sockFd = WOLFSSH_SOCKET_INVALID;
    SOCKADDR_IN_T clientAddr;
    socklen_t clientAddrSz = sizeof(clientAddr);
    char rxBuf[80];
    int ret;
    int ch;
    word16 port = wolfSshPort;
    char* host = (char*)wolfSshIp;
    const char* username = "jack";
    const char* password = "upthehill"                                                                                                                                                                                                                                                                                                                ;
    byte imExit = 0;
    byte nonBlock = 0;

    ctx = wolfSSH_CTX_new(WOLFSSH_ENDPOINT_CLIENT, NULL);
    if (ctx == NULL)
        err_sys("Couldn't create wolfSSH client context.");

    if (((func_args*)args)->user_auth == NULL)
        wolfSSH_SetUserAuth(ctx, wsUserAuth);
    else
        wolfSSH_SetUserAuth(ctx, ((func_args*)args)->user_auth);

    ssh = wolfSSH_new(ctx);
    if (ssh == NULL)
        err_sys("Couldn't create wolfSSH session.");

    if (password != NULL)
        wolfSSH_SetUserAuthCtx(ssh, (void*)password);

    ret = wolfSSH_SetUsername(ssh, username);
    if (ret != WS_SUCCESS)
        err_sys("Couldn't set the username.");

    build_addr(&clientAddr, host, port);
    tcp_socket(&sockFd);
    ret = connect(sockFd, (const struct sockaddr *)&clientAddr, clientAddrSz);
    if (ret != 0)
        err_sys("Couldn't connect to server.");

    printf("Connect to the server");
}

int main(int argc, char **argv) {
    func_args args;

    args.argc = argc;
    args.argv = argv;
    args.return_code = 0;
    args.user_auth = NULL;

    WSTARTTCP();
#ifdef DEBUG_WOLFSSH
    wolfSSH_Debugging_ON();
#endif

    wolfSSH_Init();

    ChangeToWolfSshRoot();
#ifndef NO_WOLFSSH_CLIENT
    client_test(&args);
#endif

    wolfSSH_Cleanup();

    return args.return_code;
}
Vaibhav1587 commented 5 years ago

Build log now, 

1>------ Rebuild All started: Project: wolfssl, Configuration: Debug Win32 ------
1>cl : Command line warning D9035: option 'Gm' has been deprecated and will be removed in a future release
1>wolfmath.c
1>wolfevent.c
1>wc_port.c
1>wc_encrypt.c
1>signature.c
1>sha512.c
1>sha256.c
1>sha.c
1>rsa.c
1>ripemd.c
1>random.c
1>rabbit.c
1>pwdbased.c
1>poly1305.c
1>pkcs7.c
1>pkcs12.c
1>memory.c
1>md5.c
1>md4.c
1>logging.c
1>Generating Code...
1>Compiling...
1>integer.c
1>hmac.c
1>hc128.c
1>hash.c
1>error.c
1>ecc.c
1>dsa.c
1>dh.c
1>des3.c
1>coding.c
1>chacha20_poly1305.c
1>chacha.c
1>camellia.c
1>blake2b.c
1>asn.c
1>arc4.c
1>aes.c
1>wolfio.c
1>tls13.c
1>tls.c
1>Generating Code...
1>d:\project\keil_workspace\wolfssl\wolfcrypt\src\asn.c(3186): warning C4701: potentially uninitialized local variable 'algId' used
1>d:\project\keil_workspace\wolfssl\wolfcrypt\src\asn.c(3192): warning C4701: potentially uninitialized local variable 'pkcs8KeySz' used
1>d:\project\keil_workspace\wolfssl\wolfcrypt\src\asn.c(3253): warning C4701: potentially uninitialized local variable 'pbeOidSz' used
1>Compiling...
1>ssl.c
1>ocsp.c
1>keys.c
1>internal.c
1>crl.c
1>Generating Code...
1>wolfssl.vcxproj -> C:\Users\vaibh\source\repos\SSH_Test\Debug\wolfssl.lib
1>Done building project "wolfssl.vcxproj".
2>------ Rebuild All started: Project: wolfssh, Configuration: Debug Win32 ------
2>internal.c
2>io.c
2>keygen.c
2>log.c
2>memory.c
2>port.c
2>ssh.c
2>Generating Code...
2>keygen.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library
2>wolfssh.vcxproj -> C:\Users\vaibh\source\repos\SSH_Test\Debug\Win32\wolfssh.lib
2>Done building project "wolfssh.vcxproj".
3>------ Rebuild All started: Project: SSH_Test, Configuration: Debug Win32 ------
3>main.c
3>c:\users\vaibh\source\repos\ssh_test\ssh_test\main.c(122): warning C4101: 'ch': unreferenced local variable
3>c:\users\vaibh\source\repos\ssh_test\ssh_test\main.c(120): warning C4101: 'rxBuf': unreferenced local variable
3>c:\users\vaibh\source\repos\ssh_test\ssh_test\main.c(157): warning C4716: 'client_test': must return a value
3>main.obj : error LNK2019: unresolved external symbol __imp__connect@12 referenced in function _client_test@4
3>main.obj : error LNK2019: unresolved external symbol __imp__htons@4 referenced in function _build_addr
3>main.obj : error LNK2019: unresolved external symbol __imp__inet_addr@4 referenced in function _build_addr
3>main.obj : error LNK2019: unresolved external symbol __imp__socket@12 referenced in function _tcp_socket
3>main.obj : error LNK2019: unresolved external symbol __imp__gethostbyname@4 referenced in function _build_addr
3>main.obj : error LNK2019: unresolved external symbol __imp__WSAStartup@8 referenced in function _main
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_init
3>wolfssl.lib(pwdbased.obj) : error LNK2001: unresolved external symbol _mp_init
3>wolfssh.lib(internal.obj) : error LNK2001: unresolved external symbol _mp_init
3>wolfssl.lib(dh.obj) : error LNK2001: unresolved external symbol _mp_init
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_init
3>wolfssl.lib(asn.obj) : error LNK2001: unresolved external symbol _mp_init
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_clear
3>wolfssl.lib(pwdbased.obj) : error LNK2001: unresolved external symbol _mp_clear
3>wolfssh.lib(internal.obj) : error LNK2001: unresolved external symbol _mp_clear
3>wolfssl.lib(dh.obj) : error LNK2001: unresolved external symbol _mp_clear
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_clear
3>wolfssl.lib(asn.obj) : error LNK2001: unresolved external symbol _mp_clear
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_read_unsigned_bin
3>wolfssl.lib(pwdbased.obj) : error LNK2001: unresolved external symbol _mp_read_unsigned_bin
3>wolfssh.lib(internal.obj) : error LNK2001: unresolved external symbol _mp_read_unsigned_bin
3>wolfssl.lib(dh.obj) : error LNK2001: unresolved external symbol _mp_read_unsigned_bin
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_read_unsigned_bin
3>wolfssl.lib(asn.obj) : error LNK2001: unresolved external symbol _mp_read_unsigned_bin
3>wolfssh.lib(internal.obj) : error LNK2019: unresolved external symbol _mp_toradix referenced in function _wolfSSH_oct2dec
3>wolfssl.lib(wolfmath.obj) : error LNK2001: unresolved external symbol _mp_toradix
3>wolfssh.lib(internal.obj) : error LNK2019: unresolved external symbol _mp_read_radix referenced in function _wolfSSH_oct2dec
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_read_radix
3>wolfssh.lib(io.obj) : error LNK2019: unresolved external symbol __imp__recv@16 referenced in function _wsEmbedRecv
3>wolfssh.lib(io.obj) : error LNK2019: unresolved external symbol __imp__send@16 referenced in function _wsEmbedSend
3>wolfssh.lib(io.obj) : error LNK2019: unresolved external symbol __imp__WSAGetLastError@0 referenced in function _LastError
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_forcezero referenced in function _GeneratePrivateDh186
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_forcezero
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_forcezero
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_init_multi referenced in function _GeneratePrivateDh186
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_init_multi
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_init_multi
3>wolfssl.lib(pwdbased.obj) : error LNK2001: unresolved external symbol _mp_init_multi
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_add referenced in function _wc_DhGenerateParams
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_add
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_add
3>wolfssl.lib(pwdbased.obj) : error LNK2001: unresolved external symbol _mp_add
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_add_d referenced in function _GeneratePrivateDh186
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_add_d
3>wolfssl.lib(wolfmath.obj) : error LNK2001: unresolved external symbol _mp_add_d
3>wolfssl.lib(pwdbased.obj) : error LNK2001: unresolved external symbol _mp_add_d
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_mul referenced in function _wc_DhGenerateParams
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_mul
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_mul
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_mod referenced in function _GeneratePrivateDh186
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_mod
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_mod
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_exptmod referenced in function _GeneratePublicDh
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_exptmod
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_cmp referenced in function _wc_DhCheckKeyPair
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_cmp
3>wolfssl.lib(asn.obj) : error LNK2001: unresolved external symbol _mp_cmp
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_cmp
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_cmp_d referenced in function _GeneratePrivateDh186
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_cmp_d
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_cmp_d
3>wolfssl.lib(wolfmath.obj) : error LNK2001: unresolved external symbol _mp_unsigned_bin_size
3>wolfssl.lib(pwdbased.obj) : error LNK2001: unresolved external symbol _mp_unsigned_bin_size
3>wolfssl.lib(dh.obj) : error LNK2001: unresolved external symbol _mp_unsigned_bin_size
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_unsigned_bin_size
3>wolfssl.lib(asn.obj) : error LNK2001: unresolved external symbol _mp_unsigned_bin_size
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_unsigned_bin_size
3>wolfssl.lib(wolfmath.obj) : error LNK2001: unresolved external symbol _mp_to_unsigned_bin
3>wolfssl.lib(pwdbased.obj) : error LNK2001: unresolved external symbol _mp_to_unsigned_bin
3>wolfssl.lib(dh.obj) : error LNK2001: unresolved external symbol _mp_to_unsigned_bin
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_to_unsigned_bin
3>wolfssl.lib(asn.obj) : error LNK2001: unresolved external symbol _mp_to_unsigned_bin
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_to_unsigned_bin
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_sub_d referenced in function _GeneratePrivateDh186
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_sub_d
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_copy referenced in function _GeneratePrivateDh186
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_copy
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_copy
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_iszero referenced in function _GeneratePrivateDh
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_iszero
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_set referenced in function _wc_DhGenerateParams
3>wolfssl.lib(ecc.obj) : error LNK2001: unresolved external symbol _mp_set
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_prime_is_prime referenced in function __DhSetKey
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_prime_is_prime
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_prime_is_prime_ex referenced in function __DhSetKey
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_prime_is_prime_ex
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_rand_prime referenced in function _wc_DhGenerateParams
3>wolfssl.lib(dh.obj) : error LNK2019: unresolved external symbol _mp_exch referenced in function _wc_DhGenerateParams
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_free referenced in function _wc_ecc_sign_hash_ex
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_sub referenced in function _ecc_projective_add_point
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_sub
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_mulmod referenced in function _wc_ecc_mulmod_ex
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_mulmod
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_invmod referenced in function _ecc_map
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_invmod
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_isodd referenced in function _ecc_projective_add_point
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_count_bits referenced in function _wc_ecc_sign_hash_ex
3>wolfssl.lib(rsa.obj) : error LNK2001: unresolved external symbol _mp_count_bits
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_rshb referenced in function _wc_ecc_sign_hash_ex
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_sqr referenced in function _ecc_map
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_montgomery_reduce referenced in function _ecc_map
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_montgomery_setup referenced in function _wc_ecc_mulmod_ex
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_div_2 referenced in function _ecc_projective_add_point
3>wolfssl.lib(ecc.obj) : error LNK2019: unresolved external symbol _mp_montgomery_calc_normalization referenced in function _wc_ecc_mulmod_ex
3>wolfssl.lib(asn.obj) : error LNK2019: unresolved external symbol _mp_leading_bit referenced in function _SetASNIntMP
3>wolfssl.lib(rsa.obj) : error LNK2019: unresolved external symbol _mp_2expt referenced in function _wc_CompareDiffPQ
3>wolfssl.lib(rsa.obj) : error LNK2019: unresolved external symbol _mp_to_unsigned_bin_len referenced in function _wc_RsaFunctionSync
3>wolfssl.lib(rsa.obj) : error LNK2019: unresolved external symbol _mp_set_int referenced in function _wc_CheckRsaKey
3>wolfssl.lib(rsa.obj) : error LNK2019: unresolved external symbol _mp_gcd referenced in function __CheckProbablePrime
3>wolfssl.lib(rsa.obj) : error LNK2019: unresolved external symbol _mp_lcm referenced in function _wc_MakeRsaKey
3>wolfssl.lib(rsa.obj) : error LNK2019: unresolved external symbol _mp_abs referenced in function _wc_CompareDiffPQ
3>wolfssl.lib(wolfmath.obj) : error LNK2019: unresolved external symbol _fp_zero referenced in function _mp_rand
3>wolfssl.lib(wolfmath.obj) : error LNK2019: unresolved external symbol _mp_lshd referenced in function _mp_rand
3>C:\Users\vaibh\source\repos\SSH_Test\Debug\SSH_Test.exe : fatal error LNK1120: 54 unresolved externals
3>Done building project "SSH_Test.vcxproj" -- FAILED.
========== Rebuild All: 2 succeeded, 1 failed, 0 skipped ==========
ejohnstown commented 5 years ago

Which versions of wolfSSL and wolfSSH are you building with? The last released or fresh from GitHub?

The last released versions are:

Vaibhav1587 commented 5 years ago

Same using,

ejohnstown commented 5 years ago

Pull the latest from GitHub. There has been some major updates to wolfSSH with regards to Windows builds and non-blocking. We will be doing a new release soon.