Enable sha1 when WOLFSSH_NO_SHA1_SOFT_DISABLE is enabled

wolfSSL / wolfssh

wolfSSH is a small, fast, portable SSH implementation, including support for SCP and SFTP.

https://www.wolfssl.com

367 stars 88 forks source link

Enable sha1 when WOLFSSH_NO_SHA1_SOFT_DISABLE is enabled #698

Closed miyazakh closed 3 months ago

miyazakh commented 3 months ago

sha1 is only enabled when user intentionally enables NO_SHA1_SOFT_DISABLE

ZD#17793

JacobBarthelmeh commented 3 months ago

@miyazakh can I have some background on this, what was the commands used to test it? Did you test that the soft enable of sha1 still works as expected after the change?

miyazakh commented 3 months ago

Hi @JacobBarthelmeh Sorry for being the late input. This becomes failure when accessing OpenSSH when its version is less than 8.x under using public key client authentication. I am seeing OpenSSH_8.2p1 Ubuntu-4ubuntu0.11 .

Regarding the soft enable of sha1, I am going to check it again.