wolfSSL / wolfssl-examples

Example applications using the wolfSSL lightweight SSL/TLS library
https://www.wolfssl.com
255 stars 176 forks source link

tcp_select() funcion in non tls-nonblocking example does not properly initialize select() function call. #469

Open DrClaudio73 opened 1 week ago

DrClaudio73 commented 1 week ago

In file:

in the function tcp_select(), the argument "int to_sec" is not used.

Furtermore the local varibale "struct timeval timeout;" is defined, and passed to select() invocation without being initialized.

anhu commented 1 week ago

Hello @DrClaudio73 ,

Thank you so much for letting us know about these issues. These should be quick fixes. I'll get those up very soon. Please stay tuned. In the meantime can you let us know a bit about yourself? Where are you located and what is your interest in our examples and wolfSSL? What are your goals?

Warm regards, Anthony

DrClaudio73 commented 1 week ago

Hello Anthony, thank you for your feedback. To answer your questions: my name is Claudio Cattaneo. I am based in Milan (Italy). I have already got in contact (on the 13th November 2024) with your support team (support@wolfssl.com) because I am trying to evaluate your library to verify if it does suit our needs.As I wrote there: "I am interested in evaluating if WolfSSL would suit the purpose of adding support in our applications for testing TLS implementations in OT devices, in particular for what concerns the protocols in the field of power systems management and associated information exchange. The applicable requirements are defined in the international standard IEC 62351-3 and the related testing requirements aredefined in IEC 62351-100-3." I  have also already received feedback from your Erik. He also suggested that I look into your (very precious) examples. And there, when I tried the nonblocking examples I found those issues I reported on GitHub.  Please just note that the email account I used there is my professional email address, which is not the same I use to access GitHub. I still have one another technical question that I will submit to your technical support, and then I will have to get in contact with your commercial dept. for asking commercial details. Thank you again for your attention. Kind regards

anhu commented 6 days ago

Hello Claudio,

Thank you so much for all the details. I look forward to your message to our technical support window. If you will send it today or tomorrow or over the weekend it will be I that handles it.

Warm regards, Anthony

DrClaudio73 commented 6 days ago

Actually Eric replied to my question. Since he kept open the ticket opened upon my very first email. Thank you

anhu commented 6 days ago

Excellent. Good to see. I've put up a PR for the issue . please have a look at it.

DrClaudio73 commented 6 days ago

Thank you