wolfSSL / wolfssl

The wolfSSL library is a small, fast, portable implementation of TLS/SSL for embedded devices to the cloud. wolfSSL supports up to TLS 1.3 and DTLS 1.3!

https://www.wolfssl.com

GNU General Public License v2.0

2.25k stars 805 forks source link

wolfcrypt/src/wc_pkcs11.c: iterate correctly over slotId #7736

Closed space88man closed 2 weeks ago

space88man commented 2 weeks ago

Description

When enumerating all slots (-1 passed to wolfCrypt) we should be iterating over slotId instead of the index, i.e., slot[i] and not i.

Fixes #7734

Testing

use token that does not increment slotIds from 0, e.g., NSS softoken, p11-kit
run the pkcs11 example server

Checklist

[ ] added tests
[ ] updated/added doxygen
[ ] updated appropriate READMEs
[ ] Updated manual and documentation

wolfSSL-Bot commented 2 weeks ago

Can one of the admins verify this patch?

dgarske commented 2 weeks ago

Hi @space88man ,

I don't see you setup as an approved contributor. Would you mind emailing support at wolfssl dot com to get the process started. Please include information about your project and location.

Thanks, David Garske, wolfSSL

space88man commented 2 weeks ago

I don't see you setup as an approved contributor. Would you mind emailing support at wolfssl dot com to get the process started. Please include information about your project and location.

Done - please check.

dgarske commented 2 weeks ago

Approved contributor. Thanks @space88man . Over to @SparkiDev and @wolfSSL-Bot