wolfSSL / wolfssl

The wolfSSL library is a small, fast, portable implementation of TLS/SSL for embedded devices to the cloud. wolfSSL supports up to TLS 1.3 and DTLS 1.3!
https://www.wolfssl.com
GNU General Public License v2.0
2.36k stars 834 forks source link

acert: fix holder entityName parsing. #8166

Closed philljj closed 6 days ago

philljj commented 1 week ago

Description

Fixes zd#18889.

Testing

Printing before:

$./test/test_acert -f certs/acert_ietf.pem -p
...
        Holder:
            Issuer: CN=CA
            Serial Number: 2 (0x2)
        Issuer: CN=Attribute Certificate Issuer
...

Printing after:

$./test/test_acert -f certs/acert_ietf.pem -p
...
        Holder:
            Name: CN=server.example
            Issuer: CN=CA
            Serial Number: 2 (0x2)
        Issuer: CN=Attribute Certificate Issuer
...
philljj commented 1 week ago

Retest this please.

SparkiDev commented 1 week ago

Can you please add test cases for: wolfSSL_X509_ACERT_new and wolfSSL_X509_ACERT_sign.

Thanks!

dgarske commented 1 week ago

@philljj Please resolve merge conflicts.