wolfSSL / wolfssl

The wolfSSL library is a small, fast, portable implementation of TLS/SSL for embedded devices to the cloud. wolfSSL supports up to TLS 1.3 and DTLS 1.3!
https://www.wolfssl.com
GNU General Public License v2.0
2.36k stars 834 forks source link

correct cmake script to support Open Watcom toolchain #8167

Open jmalak opened 1 week ago

jmalak commented 1 week ago

Description

CMake build by Open Watcom toolchain failed due to -Wall option Open Watcom doesn't support -Wall option it uses -wx instead -wcd=202 option suppress message about unreferenced functions

Testing

Run WolfSSL CMake build with Open Watcom toolchain It will not report incorrect -Wall option

wolfSSL-Bot commented 1 week ago

Can one of the admins verify this patch?

dgarske commented 1 week ago

Hi @jmalak ,

Can you tell us more about your project and interest in our library? I recently worked with a customer for Watcom-C compiler support, but I did not try it with CMake.

We do require a contributor agreement to be in place to accept code changes. We could treat this as a bug report if that becomes an issue. Are you planning additional pull requests?

Thanks, David Garske, wolfSSL

jmalak commented 1 week ago

Hi @jmalak ,

Can you tell us more about your project and interest in our library? I recently worked with a customer for Watcom-C compiler support, but I did not try it with CMake.

The main interest is to compile WolfSSL by Open Watcom toolchain, because OpenSSL is too much non-standard and requires many patches to do it working with Open Watcom. I thing that WolfSSL is more suitable to port to Open Watcom with much smaller number of changes. It should enable Open Watcom users to use WolfSSL for theirs applications. Main interest is build for Linux/Windows/OS/2 targets. Because Open Watcom make system is different from Microsoft an GNU, existing WolfSSL make files can not be used for Open Watcom build without big changes. Therefore simplest method to build WolfSSL is to use WolfSSL CMake support because Open Watcom toolchain is fully supported by CMake for all target OSEs (Linux/Windows/OS/2 and others).

We do require a contributor agreement to be in place to accept code changes. We could treat this as a bug report if that becomes an issue. Are you planning additional pull requests?

Yes I am planning to do more pull requests because in WolfSSL are some incompatibilities with Open Watcom which will requires small changes by example for Windows thread support.

Please If you need some agreement then give me some link to info how to process. Thanks Jiri Malak

dgarske commented 1 week ago

Hi @jmalak ,

That's wonderful! To start the process of becoming an approved contributor please email support@wolfssl.com and refernce a link to this PR and include your country of residence.

Thanks, David Garske, wolfSSL

jmalak commented 1 week ago

Sorry, I put some WIP into this branch. Now it is corrected.

kareem-wolfssl commented 1 week ago

ok to test

bandi13 commented 1 week ago

retest this please