wolfSSL / wolfssl

The wolfSSL library is a small, fast, portable implementation of TLS/SSL for embedded devices to the cloud. wolfSSL supports up to TLS 1.3 and DTLS 1.3!
https://www.wolfssl.com
GNU General Public License v2.0
2.36k stars 834 forks source link

Fix cryptodev debug output #8202

Closed LinuxJedi closed 1 day ago

LinuxJedi commented 1 day ago

Description

Cryptodev has two sections for the session info struct, cipher and hash. Our debug mode was using hash for the output even if we were using cipher, so would output random data. Simple 'if' statement to do the correct thing.

Testing

Enabling cryptodev and DEBUG_DEVCRYPTO on an STM32MP13 with OpenSTLinux and running wolfcrypt benchmark to check both hash and cipher outputs work.

Checklist

dgarske commented 1 day ago

Retest this please:

multi-test:

[check-shell-scripts] [3 of 7] [wolfssl]
    bash -n... done.
    shellcheck scripts...   real 0m3.759s  user 0m3.698s  sys 0m0.028s
    check-shell-scripts OK
/bin/bash: ./config.status: No such file or directory
make: *** [Makefile:5419: config.status] Error 127
JacobBarthelmeh commented 1 day ago

CI failure is:

unrecognized macros used:

HAVE_CRL_UPDATE_CB

Which is resolved in this PR https://github.com/wolfSSL/wolfssl/pull/8182