search

wolfSSL / wolfssl

The wolfSSL library is a small, fast, portable implementation of TLS/SSL for embedded devices to the cloud. wolfSSL supports up to TLS 1.3 and DTLS 1.3!
https://www.wolfssl.com
GNU General Public License v2.0
2.36k stars 834 forks source link

change optval type to match system #8204

Closed JacobBarthelmeh closed 14 hours ago

JacobBarthelmeh commented 1 day ago

Found when reviewing this PR https://github.com/wolfSSL/wolfssl/pull/8197

Linux:

man getsockopt 

       int getsockopt(int sockfd, int level, int optname,
                      void *optval, socklen_t *optlen);

Windows

https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-getsockopt

int getsockopt(
  [in]      SOCKET s,
  [in]      int    level,
  [in]      int    optname,
  [out]     char   *optval,
  [in, out] int    *optlen
);
dgarske commented 1 day ago

Retest this please: FAIL: scripts/ocsp-stapling_tls13multi.test

dgarske commented 1 day ago

Retest this please. CRL issues