wolfe-pack / wolfe

Wolfe Language and Engine
https://wolfe-pack.github.io/wolfe
Apache License 2.0
135 stars 17 forks source link

LBFGS not working (?) #126

Closed geospith closed 9 years ago

geospith commented 9 years ago

Batch optimisation with LBFGS runs, but returns nonsense results.

riedelcastro commented 9 years ago

How many iterations were run? Did it run to convergence? How does the objective grow/shrink?

rockt commented 9 years ago

I have the same problem in MF and I think it might be that LBFGS needs a different way of creating examples!?

riedelcastro commented 9 years ago

Oddly LBFGS works in OptimizeByLearningSpecs.

riedelcastro commented 9 years ago

Currently we don't use factorie optimization anymore. We could think about our own LBFGS implementation, but for now we can live with adagrad I think.