Bamboo 5.1 compability

[osigge]

Hi,

there is a problem with this ruby plugin and bamboo 5.1 "Server capabilities". The server capabilities page does not render completely and throws a freemarker exception. Could be a struts bug regarding to some web resources. I couldn't find any problem in the code. Any ideas?

Exception is:

2013-09-06 00:59:01,479 ERROR [http-6990-5] [runtime] Error on line 95, column 17 in template/simple/select.ftl
[INFO] [talledLocalContainer] stack.findString(parameters.listValue) is undefined.
[INFO] [talledLocalContainer] It cannot be assigned to itemValue
[INFO] [talledLocalContainer] 
[INFO] [talledLocalContainer] Error on line 95, column 17 in template/simple/select.ftl
[INFO] [talledLocalContainer] stack.findString(parameters.listValue) is undefined.
[INFO] [talledLocalContainer] It cannot be assigned to itemValue
[INFO] [talledLocalContainer] The problematic instruction:
[INFO] [talledLocalContainer] ----------
[INFO] [talledLocalContainer] ==> assignment: itemValue=stack.findString(parameters.listValue) [on line 95, column 17 in template/simple/select.ftl]
[INFO] [talledLocalContainer]  in user-directive ww.iterator [on line 66, column 5 in template/simple/select.ftl]
[INFO] [talledLocalContainer]  in include "/${parameters.templateDir}/simple/select.ftl" [on line 12, column 1 in template/aui/select.ftl]
[INFO] [talledLocalContainer] ----------
[INFO] [talledLocalContainer] 
[INFO] [talledLocalContainer] Java backtrace for programmers:
[INFO] [talledLocalContainer] ----------
[INFO] [talledLocalContainer] freemarker.core.InvalidReferenceException: Error on line 95, column 17 in template/simple/select.ftl
[INFO] [talledLocalContainer] stack.findString(parameters.listValue) is undefined.
[INFO] [talledLocalContainer] It cannot be assigned to itemValue

[wolfeidau]

Heya mate, thanks for logging this.

As mentioned in #52 I am waiting for Altassian as i can't even build the damn thing at the moment, something to do with a struts missing dependency as well..

Hopefully @i386 can help!

[osigge]

I saw that you released v2.1 of the plugin. Sadly this bug still persists. I will look further to investigate this issue.

[wolfeidau]

OK Sorry, been busy.

Can you grep the log for my statements *Locator?

[wolfeidau]

Take a look at the example logs in #28 to see what I am looking for.

[osigge]

Here's the output:

2013-09-06 00:41:33,785 INFO [http-6990-4] [RubyLocatorServiceFactory] Loaded ruby runtime managers [au.id.wolfe.bamboo.ruby.system.SystemRubyRuntimeLocatorService@6f69d5ca, au.id.wolfe.bamboo.ruby.rbenv.RbenvRubyRuntimeLocatorService@d52f9eb, au.id.wolfe.bamboo.ruby.rvm.RvmRubyRuntimeLocatorService@4295ba22, au.id.wolfe.bamboo.ruby.windows.WindowsRubyRuntimeLocatorService@73ef3054] 
2013-09-06 00:41:33,789 INFO [http-6990-4] [RubyLocatorServiceFactory] Loaded ruby runtime managers [au.id.wolfe.bamboo.ruby.system.SystemRubyRuntimeLocatorService@a977666, au.id.wolfe.bamboo.ruby.rbenv.RbenvRubyRuntimeLocatorService@5dde27f8, au.id.wolfe.bamboo.ruby.rvm.RvmRubyRuntimeLocatorService@24123aed, au.id.wolfe.bamboo.ruby.windows.WindowsRubyRuntimeLocatorService@28dab01b] 
2013-09-06 00:41:35,086 INFO [http-6990-4] [RbenvRubyRuntimeLocatorService] Searching for rbenv installation in users home directory located at - /Users/oliversigge/.rbenv
2013-09-06 00:41:35,086 INFO [http-6990-4] [RvmRubyRuntimeLocatorService] Searching for rvm installation in users home directory located at - /Users/oliversigge/.rvm
2013-09-06 00:41:35,086 INFO [http-6990-4] [RvmRubyRuntimeLocatorService] Search for rvm installation in system paths /usr/local/rvm
2013-09-06 00:41:35,309 INFO [http-6990-4] [RbenvRubyRuntimeLocatorService] Searching for rbenv installation in users home directory located at - /Users/oliversigge/.rbenv
2013-09-06 00:41:35,309 INFO [http-6990-4] [RvmRubyRuntimeLocatorService] Searching for rvm installation in users home directory located at - /Users/oliversigge/.rvm
2013-09-06 00:41:35,309 INFO [http-6990-4] [RvmRubyRuntimeLocatorService] Search for rvm installation in system paths /usr/local/rvm

[wolfeidau]

So it isn't finding any rubies at all?

[osigge]

Hitting "Detect server capabilities" button finds 2 rubies and adds them.

[wolfeidau]

Just tested on my development bamboo running in the SDK and i get the same error.

From memory that has always been the case.

What is the issue which this is causing? Is it just the partial render (mine is rendering fine even with the error).

[osigge]

Yes, it render partially. That means, the sidebar on the left is gone and so is the "Add" button for adding new capabilities. In dev mode ("atlas-run") the view renders fine. But the production version of bamboo throws the render error into the view and stops rendering.

[wolfeidau]

wow, that is odd.

I would raise a ticket with Atlassian and get them to track it down.

If you uninstall my plugin and try it does it still throw the error?

Hopefully we can narrow this down.

[osigge]

As long as the ruby plugin is disabled, the server capability view works fine.

[osigge]

Ok, I got it. At least the exception isn't thrown any longer. I will create a pull request so you can review the changes.