search

wolfenste / tictactoe

0 stars 0 forks source link

invalid Game can be constructed #17

Closed flavius closed 6 years ago

flavius commented 6 years ago

Think of error conditions and throw exceptions in the constructor if the game which is about to be constructed is not valid. Read your document rules.md.

Don't forget to write tests first.

wolfenste commented 6 years ago

Yes, I know, I am aware of that. Both players can be X or 0 or even worse (because Player's constructor is faulty too), we can have non_symbol players. Map can be constructed with an array of non object elements. I have a lot to do. :) For me the most difficult part is to find relevant commit messages and test method identifiers. I do not know yet, maybe I should keep a consistent commit message style; by now it is a mess.

wolfenste commented 6 years ago

Actually I do know, I read about that, commit messages should follow a consistent style.