wolfgangw / backports

Deep inspection of digital cinema packages
27 stars 12 forks source link

Emit error for compositions mixing SMPTE and Interop? #103

Open matmat opened 8 months ago

matmat commented 8 months ago

I have this:

dcp_inspect v1.2023.12.20 (asdcplib 2.10.35, ruby 3.0.2 x86_64-linux-gnu): 
(...)
Reel 1:
308053  03:33:55+13 @ 24.0  Entry 00:00:00+00  5c55d71d  MainPicture    (SMPTE, 03:33:55+13, plaintext, 1998x1080, avg 177.69 Mb/s, max 204.19 Mb/s, pictures)
308053  03:33:55+13 @ 24.0  Entry 00:00:00+00  506b5da3  MainSound  (SMPTE, 03:33:55+13, plaintext, 6ch 48kHz 24bps, RMS -36.74 dBFS |▃|▃|▄|▃|▃|▃|, Peak -2.01 dBFS |▇|▇|▇|▅|▅|▅|, audio)
308053  03:33:55+13 @ 24.0  Entry 00:00:00+00  31659dec  MainSubtitle   (DCSubtitle, 1240 subtitles, 00:00:54+16 'Sir.' - 03:27:02+00 'Please eat, sir.')
Total duration:
308053  03:33:55+13 @ 24.0
(...)
Hint: CPL c82b2e3e-8d8b-4aeb-bd81-a7af14b632e2: Composition type: Mixed: Supplemental/VF/External
(...)

Maybe mixing SMPTE audio and video with Interop subtitles should be considered an error?

Don't know if playback fails (probably not), but still kinda serious in my opinion.

matmat commented 8 months ago

Another example:

dcp_inspect v1.2023.12.20 (asdcplib 2.10.35, ruby 3.0.2 x86_64-linux-gnu):
(...)
Reel 1:
159840  01:51:00+00 @ 24.0  Entry 00:00:00+00  422ef3e5  MainPicture    (MXF Interop, 01:51:00+00, plaintext, 1998x1080, avg 174.01 Mb/s, max 249.50 Mb/s, pictures)
159840  01:51:00+00 @ 24.0  Entry 00:00:00+00  ae43af61  MainSound  (MXF Interop, 01:51:00+00, plaintext, 6ch 48kHz 24bps, RMS -33.86 dBFS |▃|▃|▄|▂|▃|▃|, Peak -3.02 dBFS |▆|▅|▇|▂|▄|▅|, audio)
159840  01:51:00+00 @ 24.0  Entry 00:00:00+00  62b4a774  MainSubtitle   (SMPTE, 01:51:00+00, plaintext, timed text)
Total duration:
159840  01:51:00+00 @ 24.0
(...)
Hint: CPL e08e6536-3614-45b6-afc4-f45781cf9084: Composition type: Mixed: Supplemental/VF/External
(...)
wolfgangw commented 8 months ago

@matmat, thanks. The hint is wrong, for one thing (obviously not supplemental/VF packages). Probably something I've broken just recently. Tracking it down...

wolfgangw commented 8 months ago

See latest, should be fixed. If you can, let me know.