search

wolfgangw / backports

Deep inspection of digital cinema packages
27 stars 12 forks source link

Font Id in cinecanvas subtitle #31

Closed liloneum closed 11 years ago

liloneum commented 11 years ago

One more, for the pleasure:

<LoadFont URI="Arial.ttf" Id="Arial"> <Font Id="arial"

In that case the font will not be loaded...

wolfgangw commented 11 years ago

Sorry for being thick but do you literally mean the (invalid) <Font Id="arial" string (missing the closing ">") or is this about the Id string itself?

liloneum commented 11 years ago

Oh, sorry, the text did not appear correctly because of the tags... In "LoadFont" tag, if Id="Arial" and then, in "Font" tag, if Id="arial" (I mean two different names: in this case the A in upper or lower case), the font will not be loaded. A detail, but already encountered.

wolfgangw commented 11 years ago

Fixed (see https://github.com/wolfgangw/backports/commit/81afb0f58a76a3fd8e8746c96d2aae9cab7273bd). Please test and confirm.

Thanks!

liloneum commented 11 years ago

Reel 1: DCSubtitle: Referenced font Id 'arial' does not match the Id 'Arial' declared in LoadFont. Font cannot be loaded

Done!

wolfgangw commented 11 years ago

Great, thanks.