search

wolfi-dev / wolfictl

A CLI used to work with the Wolfi OSS project
Apache License 2.0
54 stars 54 forks source link

Dependency / build-order solver does not consider runtime deps . #1217

Open smoser opened 2 weeks ago

smoser commented 2 weeks ago

I noticed this when putting up a PR to wolfi that changed lots of packages.

It appeared to me that the solver did not consider runtime dependencies, but c-i was doing test immediately after build. So for a package P that depended on A for build and A and C for runtime, there was no guarantee that C would be built before P.

It is possible that this is acceptable, and the build/test should simply be changed to do "build all the things and then test all the things". I don't have a good argument against that, but the current process in github actions was 'make package/' and then 'make test/'.

xnox commented 1 week ago

In elastic builds I believe all builds are done first, then tests.

We could adopt same for GHA builds too. Not sure how much work that would be.