search

wolfpld / tracy

Frame profiler
https://tracy.nereid.pl/
Other
10.24k stars 691 forks source link

Fix upper limit of unique SourceLocations w.r.t. manual #908

Closed slomp closed 1 month ago

slomp commented 1 month ago

The manual mentions 65534 unique source locations: https://github.com/wolfpld/tracy/blob/1bd84419c09dae2b5f9e2c8f5e29697e911fed38/manual/tracy.tex#L667

So it looks like the current assert is wrong: https://github.com/wolfpld/tracy/blob/1bd84419c09dae2b5f9e2c8f5e29697e911fed38/server/TracyWorker.cpp#L3336

and should be:

assert( m_data.sourceLocationExpand.size() < std::numeric_limits<uint16_t>::max() );
slomp commented 1 month ago

Ah, sorry, just realized about the split between static and dynamic. My bad.