search

wolframtheta / BotCRUPC

GNU General Public License v3.0
2 stars 12 forks source link

Translated the bot #6

Closed j4cobgarby closed 7 years ago

j4cobgarby commented 7 years ago

I don't know if I've done exactly what you wanted, it wasn't overly clear.

I created a new file for the translations, but I wasn't sure if you wanted this, or if you wanted it as another function. If this isn't what you wanted, I'd be happy to change it.

wolframtheta commented 7 years ago

Yeah its okey. It's true that it's not clear if you have to create another file or not.. I will modify it.

yotam180 commented 7 years ago

@wolframtheta maybe it's possible to create a helpful documentation for the language API to make it clearer

j4cobgarby commented 7 years ago

@yotam180 @wolframtheta I agree, maybe in a CONTRIBUTING.md file. If the current translations are implemented incorrectly, though, I'd be happy to correct them.

yotam180 commented 7 years ago

The current translations are provided just as they should be. It just seemed to me that you were uncertain about the way you should implement them so I concluded that it was not clear enough. Am I right?

j4cobgarby commented 7 years ago

You're right - until now I wasn't sure if they were implemented properly.

wolframtheta commented 7 years ago

You have the instructions here https://github.com/wolframtheta/BotCRUPC/issues/1