[REQUEST] Movies support?

[llunawolf]

Please describe what you want to be added/changed: Support for the "Filme" (Movies) tab on Aniworld. It's often used for Specials and Movies (although it's actually mostly specials it seems)

Only the naming of the files might be complicated here because I'm not sure if the order Aniworld has is really trustworthy (in the sense that they might add ones in-between and scramble the order). Maybe just use the titles here? The things on that tab are usually very chaotic anyway, so manual renaming and organization would be needed here anyways.

Possible Solutions if you have any:

• Take in "Filme" or similiar for the season field
• Use /filme in the URL instead of /staffel-x
• Essentially do the same thing as with seasons, but with different file naming.

[llunawolf]

(If this is already possible, please tell me. I just searched for /filme in the code through GitHub and couldn't find anything) Would contribute myself, but I have no clue about Python.

s.to seems to have a tab like this too. You can use toradora on aniworld and initial-d on s.to for testing.

[wolfswolke]

@llunawolf you can now use this to download Movies: python .\main.py anime toradora Ger-Sub True The Bool at the end is the Movie Bool. If its true it will download filme/film-X and if its False it will download staffel-X/episode-X Please test it and tell me if it works.

[alternone]

Tested and works well. I just started to implement the function as well last evening. Just discovered before your new commit :D

PS: You should check out argparse - that could replace several pieces of your code and also the shell/batch part as it also include checks, defaults, enums and many more. https://docs.python.org/3/library/argparse.html I use it in nearly all projects at work. It also generated a man page with --help

[wolfswolke]

Hi @alternone . I will look into it some day. But currently im using 90% of my spar time to work on the DeathgarenRebirth Project. If you want you can open a PR or i will implement it once i have some time.

[llunawolf]

So um, the moving downloading works great, but uh... how do I download non-movies now?

python3 "main.py" "anime" "pokmon" "Deutsch" "False" "6"
python3 "main.py" "anime" "pokmon" "Deutsch" "false" "6"
python3 "main.py" "anime" "pokmon" "Deutsch" "True" "6"
python3 "main.py" "anime" "pokmon" "Deutsch" "true" "6"

All of these download the movie.

[wolfswolke]

Temp fix dont use a season override. forgot the logic there...

[wolfswolke]

Actualy not a me bug! py just doesnt understand Bools as arguments... (py310_AniWorldScraper) PS D:\python\projects\AniWorldScraper> python .\main.py anime pokmon Ger-Sub 6 DEBUG:src.constants:cli argument detected on position:1 with value:anime DEBUG:src.constants:cli argument detected on position:2 with value:pokmon DEBUG:src.constants:cli argument detected on position:3 with value:Ger-Sub DEBUG:src.constants:cli argument detected on position:4 with value:6

[Bramdarl]

Actualy not a me bug! py just doesnt understand Bools as arguments...

this should help: movie = (parse_cli_arguments(False, 4).lower() == 'true') # True = movie. False = episode

[wolfswolke]

@llunawolf Can you please try if the issue is fixed for you as well? Just implemented @Bramdarl fix which worked on my Machine and Test machine.

[Monokuma11]

I tried the new version with a movie, but got those exceptions in return

[wolfswolke]

I tried the new version with a movie, but got those exceptions in return

@Monokuma11 you are using the Windows Store version of python. This version is from what I know very buggy and you might need to run the script as admin etc because the permissions are not set correctly sometimes.

[Monokuma11]

I see. I will deinstall the windows version then and get it from the web

[Monokuma11]

The error stays :(

[wolfswolke]

@Monokuma11 please try the latest version which was just merged. (Git clone...) If that still does not work create a new issue please with the Anime Name, Your settings and also the log output.

[wolfswolke]

Closed. No Response from original creator.