search

wolftype / versor

Versor Geometric Algebra Library
wolftype.github.io/versor/devel/html/
290 stars 47 forks source link

Move vsr to include/vsr and start cleanup of toplevel folder #8

Closed tingelst closed 9 years ago

tingelst commented 9 years ago

This PR moves the vsr include directory to include/vsr as a first step to clean up the top level folder. The examples that is affected by this move is updated and building successfully. I propose to start using #include <vsr/folder/file.h> for includes as shown in examples/xFabrikChain.cpp

wolftype commented 9 years ago

thanks lars -- could you please explain a bit more the motivations behind this organizational change?

i've seen libraries where the headers are in a folder with the library name, and also libraries where the headers are in a folder called include ("include/folder/filename.h"), but not so sure i've seen libraries where it goes "include/libname/folder/filename.h"

tingelst commented 9 years ago

It really just is that I think it is cleaner, and most of the libraries I use have an include folder in the top level.

An example is #include <vsr/draw/vsr_cga3D_draw.h>. I think this clean and readable.

I might also propose to change to #include <vsr/draw/cga3d_draw.h>, but that can wait to a later PR:)

wolftype commented 9 years ago

got it thanks lars, keep cleaning!

p

wolftype commented 9 years ago

i also agree that the "vsr_" prefix is redundant now ...