wolfv / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
GNU General Public License v2.0
1 stars 0 forks source link

patch for play file on click mouse, if a file was stopped. #599

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
@@ -1444,6 +1433,7 @@
                 gmtk_media_player_set_state(GMTK_MEDIA_PLAYER(media), MEDIA_STATE_PAUSE);
                 break;
             case MEDIA_STATE_PAUSE:
+            case MEDIA_STATE_STOP:
                 gmtk_media_player_set_state(GMTK_MEDIA_PLAYER(media), MEDIA_STATE_PLAY);
                 break;
             default:

Original issue reported on code.google.com by censureblock on 11 Feb 2012 at 11:29

Attachments:

GoogleCodeExporter commented 9 years ago
So you want the case where the video has stopped (because it has completed), 
and clicking the mouse plays the same video again? I'm not sure about that, can 
you give me a use case?

Original comment by kdeko...@gmail.com on 12 Feb 2012 at 1:41

GoogleCodeExporter commented 9 years ago
Yes, you are right.
I think so it comfortable.

Original comment by censureblock on 13 Feb 2012 at 2:07

GoogleCodeExporter commented 9 years ago
And clicking the play button is so hard?

Original comment by kdeko...@gmail.com on 13 Feb 2012 at 2:14

GoogleCodeExporter commented 9 years ago
Yes, it is very difficult.
need to move a mouse and click the play button.
Too much going for it to do.

Original comment by censureblock on 13 Feb 2012 at 5:34

GoogleCodeExporter commented 9 years ago
I'm going to reject this patch, as there are other workarounds..

1. You can set the Loop option so that the media will be continuously played
2. You can press the enter key and most of the time it will activate play and 
it will start again.

Stop is a special case to me, and I want treat it correctly.

Original comment by kdeko...@gmail.com on 20 Feb 2012 at 2:46