wolfv / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
GNU General Public License v2.0
1 stars 0 forks source link

Hot-keys doesn't work in other lang layuot #600

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open player
2. Change keyboard layout in other lang (Russian in my case)
3. ??????
4. PROFIT

What is the expected output? What do you see instead?
Hot-keys doesn't working. They should really.

What version of the product are you using? On what operating system?
1.0.5, Arch Linux (Kernel 3.2.6-2, GNOME 3.2.2)

Please provide any additional information below.
In fact not all hot-keys acts like I described below. Seem that only one letter 
doesn't work. Like a "f" for fullscreen or "a" for aspect settings

Original issue reported on code.google.com by Dant...@gmail.com on 20 Feb 2012 at 4:29

GoogleCodeExporter commented 9 years ago
Did you try the customized hotkey definitions under Edit -> Preferences. I have 
asked for testing on this feature since version 1.0.4 and so far nobody has 
reported if it works or not. I was going to extend this functionality, but 
without confirmation I feel like I am wasting my time.

Original comment by kdeko...@gmail.com on 20 Feb 2012 at 4:43

GoogleCodeExporter commented 9 years ago
I've changed setting to this (attached file) and it's seem doesn't work 
properly. At this point I have "f" toggles fullscreen (on and off) and "g" 
turns fullscreen on, but not off.

Original comment by Dant...@gmail.com on 20 Feb 2012 at 5:00

Attachments:

GoogleCodeExporter commented 9 years ago
Ok, I think I see the problem and it is more of a lack of 
coverage/understanding. 

With the key customization, it only customizes the menu shortcuts at this 
point. The other keys are not covered (this is where I was planning to enhance, 
but since no feedback, I didn't continue the work). 

Also 'f' is a special keyboard shortcut. It is not a menu shortcut, but a 
captured key. Additionally "Full Screen" adds some additional issues, since 
when the menu bar is hidden the menu shortcuts do not work anymore.

So 'f' will always toggle between fullscreen and not (I have not enabled 
customizing for this key yet).

Ctrl-F (which is the default value for the Fullscreen shortcut) and the value 
you have changed to 'g' will take you to fullscreen mode, but since the menu is 
not visible it will not exit the mode because the shortcut is not active (f & 
ESC will take you out of fullscreen mode).

So if the key customizing in general (not fullscreen mode at this point) is 
working for you. Let me know and I'll finish up the keyboard shortcut mapping. 
This may take me a little bit due to my schedule at work, but I will work on 
it).

Original comment by kdeko...@gmail.com on 20 Feb 2012 at 5:11

GoogleCodeExporter commented 9 years ago
So as far as I understood you, there is hotkeys of MPlayer (like "f" - 
fullscreen, "z" and "x" - syncing subs) and hotkeys of your player that should 
work only when menu is visible?

Original comment by Dant...@gmail.com on 20 Feb 2012 at 6:00

GoogleCodeExporter commented 9 years ago
I think you got it backwards. The keys you can customize in the Keyboard 
Preferences only work in non-fullscreen mode. The keys you cannot customize 
should work in both fullscreen and non-fullscreen mode. 

However, I am working on fixing this. I just put a patch into SVN that allows 
the customized FullScreen key to toggle in and out of fullscreen mode. Now that 
I have that one working the rest should be relatively easy. The hard part is 
customizing the non-menu keyboard shortcuts and that will take some time.

Original comment by kdeko...@gmail.com on 20 Feb 2012 at 6:29

GoogleCodeExporter commented 9 years ago
Ah, okay. But there are some features in that list that are not supposed to 
work in fullscreen like a "Details" (because there is no place to show it) and 
some features that should work like a change size of subs. Is this what you 
want to do?

Original comment by Dant...@gmail.com on 20 Feb 2012 at 6:45

GoogleCodeExporter commented 9 years ago
That is correct

Original comment by kdeko...@gmail.com on 20 Feb 2012 at 7:54

GoogleCodeExporter commented 9 years ago
At this point you probably should create new issue or something, because this 
have not really proper name. Key preferences working okay (except discussed 
issue) in both languages. 

And there is one more small thing, subs don't resetting when you open new file 
via File - Open (Ctrl - O) or something. New video file, old subtitles. But 
that is not a big deal)

Thank you for time.

Original comment by Dant...@gmail.com on 20 Feb 2012 at 8:05

GoogleCodeExporter commented 9 years ago
Чувак, юзай мой патч в предыдущем посте.
Все кнопки намертво забиты в коде 
программы, в настройках они даны только для 
ознакомления с ними.
а автор программы - упертый как осел.

Original comment by censureblock on 21 Feb 2012 at 8:03

GoogleCodeExporter commented 9 years ago
censureblock, I'm not that stubborn.. and there are reasons I am not taking all 
your patches, they are incomplete and do not make sense in all cases.

Original comment by kdeko...@gmail.com on 21 Feb 2012 at 1:40