search

wolfv / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
GNU General Public License v2.0
1 stars 0 forks source link

RFE: better playlist support #78

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
It would be nice if gnome-mplayer supported the nullsoft PLS and M3U
playlist formats properly (see:
http://forums.winamp.com/showthread.php?threadid=65772 ). This would allow
metadata to be read in from the playlist when possible--loading mplayer to
read the metadata on each file takes forever with a large playlist. Plus,
right now (current SVN), real PLS files are completely broken. Maybe you
could even use a library like the totem playlist parser lib (
http://library.gnome.org/devel/totem-pl-parser/ ), if it doesn't pull in a
bunch of dependencies?

Original issue reported on code.google.com by MonkeeS...@gmail.com on 28 Oct 2008 at 8:17

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Here is a patch that synchronizes the GIO / normal playlist parsing. It also 
adds
support for parsing the TitleN and LengthN keys of PLS files (just skips them 
for
now), skips blank lines, and supports relative paths for parse_basic playlists.

Original comment by MonkeeS...@gmail.com on 28 Oct 2008 at 10:42

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Same as other patch, but also refactors parse_basic to no repeat the same thing
between GIO and standard IO.

Original comment by MonkeeS...@gmail.com on 28 Oct 2008 at 3:04

Attachments:

GoogleCodeExporter commented 8 years ago 
Patch Applied... thanks

Original comment by kdeko...@gmail.com on 28 Oct 2008 at 5:19

GoogleCodeExporter commented 8 years ago 
Hi,

Couple of slight fixes from previous patch. Had the logic wrong for when to 
expand
path (was tired) and forgot to free a couple of variables. Patch is against 
current
SVN with previous patch applied.

Original comment by MonkeeS...@gmail.com on 29 Oct 2008 at 2:28

Attachments:

GoogleCodeExporter commented 8 years ago 
Looks ok, applied

Original comment by kdeko...@gmail.com on 29 Oct 2008 at 2:44

GoogleCodeExporter commented 8 years ago 
Good lord...I must be getting senile with old age or something. There were 
memory and
logic errors with the last patches (several!)--try loading a m3u playlist 
several
times to see what I mean. I think I've ironed them all out now. Here is a 
properly
refactored, final patch for this. Sorry for the noise. But I think you'll agree 
that
the end result is "smooth, like butter." :)

Original comment by MonkeeS...@gmail.com on 29 Oct 2008 at 5:46

Attachments:

GoogleCodeExporter commented 8 years ago 
I committed your patches and it totally broke GIO playlist loading... I'm 
redoing the
patch... also, I noticed several memory leaks even in the latest patch. I will 
be
fixing those as well.

Original comment by kdeko...@gmail.com on 29 Oct 2008 at 6:14

GoogleCodeExporter commented 8 years ago 
Ok, I made some changes to SVN based on your patches. I think it is better now. 
At
least playlists load for me now in GIO mode.

Original comment by kdeko...@gmail.com on 29 Oct 2008 at 6:26