search

wolkykim / libasyncd

Libasyncd is an embeddable event-based asynchronous Message/HTTP server framework for C/C++.
http://wolkykim.github.io/libasyncd/
Other
174 stars 36 forks source link

Improve handling of SSL_CTX #10

Closed dtoubelis closed 9 years ago

dtoubelis commented 9 years ago

This is proposed improvement for handling SSL_CTX as described in issue #6. I updated ad_server.c as well as samples and the documentation.

There are two commits here:

  1. The first one (5e824e2) removes old functionality and replaces it with the new one. This is the cleanest approach but it breaks backward compatibility for existing code that uses HTTPS.
  2. The second one (3b2a0cf) re-introduces the old behavior and makes the code backward compatible but leaves undesirable artefacts.

I leave it up to you to choose what approach you like better, so merge at will :smile:

Note: that this patch overlaps with one I made for issue #5, so please review and apply the #5 first.

wolkykim commented 9 years ago

Could you take out "Revert old behavior for backward compatibility"? I'd like to see 1 and best way of doing this and keep the code simple. Thanks for the great improvement.