search

wolph / numpy-stl

Simple library to make working with STL files (and 3D objects in general) fast and easy.
http://numpy-stl.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
624 stars 105 forks source link

solid names converted to lowercase #115

Closed dfransos closed 4 years ago

dfransos commented 4 years ago

At lines 59 and 152 of stl.py there's a lowercase conversion, to further match a substring to my understanding. This causes in turn all the solid names to be converted to lowercase, that's an issue when rewriting the stl after manipulation. Can we just fix this by temp lowercasing only for the sake of string comparison, without changing the object in place?

wolph commented 4 years ago

Looks like except for the solid check it's all case insensitive anyhow so I see no reason why this can't be fixed :)

I'll create a new release