search

wolph / numpy-stl

Simple library to make working with STL files (and 3D objects in general) fast and easy.
http://numpy-stl.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
624 stars 105 forks source link

Revert "converted normals to unit vectors to fix #108" #147

Closed bwoodsend closed 3 years ago

bwoodsend commented 3 years ago

This reverts commit dcbe8cd162e9312b7d80ac4e1ff557af576cd996 which caused Mesh.units to no longer be unit-vectors (i.e. have magnitude of 1.0). Fixes #142.

It's not a true revert as you've made further changes since which caused minor merge conflicts. I've hopefully preserved your further changes.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f1fc0b687e52234614a78fbee49fa2a43debdc0f on bwoodsend:develop into 024b3b85184c509d10c60b6a51a938316669f7ba on WoLpH:develop.

codecov[bot] commented 3 years ago

Codecov Report

Merging #147 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          511       507    -4     
  Branches        60        59    -1     
=========================================
- Hits           511       507    -4
Impacted Files Coverage Δ
stl/base.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 024b3b8...f1fc0b6. Read the comment docs.