search

wolph / numpy-stl

Simple library to make working with STL files (and 3D objects in general) fast and easy.
http://numpy-stl.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
624 stars 105 forks source link

Rename check to is_closed #90

Closed NicholasWon47 closed 5 years ago

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 75e978aa28eaea44e1da979e7b8bfcca0db2f3e0 on NicholasWon47:develop into 86d2a0fc3def1f96563791a4e51713cc5cd12ca3 on WoLpH:develop.

wolph commented 5 years ago

For the sake of backwards compatibility the check method needs to stay. But it could simply wrap the is_closed method. The idea is that multiple checks could be added over time, not just checking for closed geometries

NicholasWon47 commented 5 years ago

I understood. In that cases, the method needs some docs :)

codecov[bot] commented 5 years ago

Codecov Report

Merging #90 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #90   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            5      5           
  Lines          490    490           
  Branches        57     57           
======================================
  Hits           490    490
Impacted Files Coverage Δ
stl/stl.py 100% <ø> (ø) :arrow_up:
stl/base.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86d2a0f...75e978a. Read the comment docs.

NicholasWon47 commented 5 years ago

I simply wrapped 'is_closed' method. so you can use them in check method as a check routines.

wolph commented 5 years ago

Looks great. Thank you :)