wolph / numpy-stl

Simple library to make working with STL files (and 3D objects in general) fast and easy.

http://numpy-stl.readthedocs.org/

BSD 3-Clause "New" or "Revised" License

624 stars 105 forks source link

Fix for issue #52 #94

Closed hroncok closed 5 years ago

hroncok commented 5 years ago

See https://github.com/WoLpH/numpy-stl/issues/52

TODO:

[x] Make the PyQt5 test dependency optional
[x] Fix the issue with uselocale() from Cython code
[x] Check macOS
[x] Check cura

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling 6736fa3949b581b501762c3040628ffe9a9fd1a7 on hroncok:i52 into db98f18ecec032acb50a9687964d0b7cbb17a527 on WoLpH:develop.

wolph commented 5 years ago

For ease we could make the PyQt5 optional and simply add a separate tox+travis environment for that. It will still get automatic tests but it saves everyone from installing PyQt5 which can be a pain if there are no binaries available for your platform.

hroncok commented 5 years ago

I've added it to Python 3.6 nix environment and will focus on the fix. Later we can do it differently.

hroncok commented 5 years ago

I have a fix that works on my Linux. Not sure if it should be non-Windows or Linux only (aka I have no idea if it works / is required on MacOS or FreeBSD). It is also most likely glibc only and never tested on MUSL.

codecov[bot] commented 5 years ago

Codecov Report

Merging #94 into develop will not change coverage. The diff coverage is 100%.

@@          Coverage Diff           @@
##           develop    #94   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            5      5           
  Lines          492    489    -3     
  Branches        57     57           
======================================
- Hits           492    489    -3

Impacted Files	Coverage Δ
stl/stl.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db98f18...6736fa3. Read the comment docs.

hroncok commented 5 years ago

Also, I haven't tested this in cura yet.

hroncok commented 5 years ago

Fixes the cura issue.

hroncok commented 5 years ago

OK, it didn't compile on macOS, so I've used IF Linux.

I'm basically done now. Please let me know if I shell approach this differently.

wolph commented 5 years ago

The fix looks great to me so I'm very happy with it. If osx users report the issue I can always fix it myself. You've done the hard work already.

Once again thank you so much for all of the effort! I'd never have found it myself.