search

wolph / numpy-stl

Simple library to make working with STL files (and 3D objects in general) fast and easy.
http://numpy-stl.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
624 stars 105 forks source link

please consider renaming the argument to 'vector' instead of 'matrix' #98

Closed komahanb closed 5 years ago

komahanb commented 5 years ago

https://github.com/WoLpH/numpy-stl/blob/1cb4c5013c9b5a2dee0500e06b574ee0f4d19ca3/stl/base.py#L491

wolph commented 5 years ago

It's not a single vector though so that would not be accurate

Since every triangle consists of 3 points this returns a list with the length being equal to the amount of triangles in your mesh: https://github.com/WoLpH/numpy-stl/blob/1cb4c5013c9b5a2dee0500e06b574ee0f4d19ca3/stl/base.py#L500

The loop is to get through all 3 points of the triangle

komahanb commented 5 years ago

You are right. Thanks for the clarification.