search

wolph / python-statsd

Python Client for the Etsy NodeJS Statsd Server
http://readthedocs.org/docs/python-statsd/en/latest/
BSD 3-Clause "New" or "Revised" License
110 stars 39 forks source link

Why is setup_requires=['nose', 'mock', 'coverage'] needed? #27

Closed victoradan closed 10 years ago

victoradan commented 10 years ago

I ask because I ran into issues while trying to install python-statsd through a proxy. e.g., ('pip install --proxy myproxy.net:80 python-statsd'). The install fails because its unable to download the setup_requires packages. If I remove the 'setup_requires', install succeeds.

Still trying to figure out the issue. Seems to be related with _setuptools/ssl_support.py(184)httpsopen() though.

So the root cause of my install problem is not the _setuprequires=['nose', 'mock', 'coverage'] line, but it made me wonder why this is even needed since these are test dependency modules. Are they needed for the package to function? If it's just for tests, should they be in _testsrequire?

wolph commented 10 years ago

That's just a remnant of the past I suppose, it should indeed be in the tests_require instead.

As for your issue, perhaps your OpenSSL library has been updated without relinking it with Python?

victoradan commented 10 years ago

Thanks for the quick reply. The install fails with setuptools v0.9.8, the default packaged with virtualenv v1.10. setuptools v1.4 seems to have a fix and the install runs fine.

As for the 'setup_requires' in python-statsd, I'll submit a patch to move those to 'tests_require' if you agree.

wolph commented 10 years ago

Thanks for the offer but it won't be necessary. I have already released a new version with this change.

On Thursday, November 21, 2013, victoradan wrote:

Thanks for the quick reply. The install fails with setuptools v0.9.8, the default packaged with virtualenv v1.10. setuptools v1.4 seems to have a fix and the install runs fine.

As for the 'setup_requires' in python-statsd, I'll submit a patch to move those to 'tests_require' if you agree.

— Reply to this email directly or view it on GitHubhttps://github.com/WoLpH/python-statsd/issues/27#issuecomment-29009773 .

victoradan commented 10 years ago

Awesome! Thanks. May I ask for a final request? Mind uploading to pypi.python.org? Best. V.

wolph commented 10 years ago

Apparently the deployment earlier today didn't work. Just redeployed and it seems to be available now :)