Fix for sending 0ms entries.

wolph / python-statsd

Python Client for the Etsy NodeJS Statsd Server

http://readthedocs.org/docs/python-statsd/en/latest/

BSD 3-Clause "New" or "Revised" License

110 stars 39 forks source link

Fix for sending 0ms entries. #31

Closed anthroprose closed 10 years ago

anthroprose commented 10 years ago

DEBUG: Bad line: 0,ms in msg "production.timer:0|ms" https://github.com/etsy/statsd/blob/5b900711191a9c5cfd536c877a3c119d1df5679a/lib/helpers.js Line 35: return isNumber(fields[0]) && Number(fields[0]) > 0;

statsD expects a > 0 number for ms counters.

wolph commented 10 years ago

How did you get a measurement of less than 10 microseconds? Sounds like you might have a bug in your code :)

I'll merge it as soon as I've fixed the tests to succeed again.

anthroprose commented 10 years ago

Just the Ops guy here... I noticed other projects were taking the 0ms issue into account, for me its mostly headache of extra network i/o.

I will however open internal tickets about the 0ms timing on things, (its happening with a few different pieces of code that are very active, so I know it works sometimes and does not current correlate with exceptions...)

anthroprose commented 10 years ago

https://github.com/etsy/statsd/pull/397