search

wolpi / prim-ftpd

FTP server app for android
Other
643 stars 81 forks source link

[Req] Compatibility with Nvidia Shield #257

Open PietroPizzi69 opened 2 years ago

PietroPizzi69 commented 2 years ago

Hi,

your App is great but unfortunately the Google App Store says I can't install it on my Nvidia Shield.

Is this because you have to "whitelist" the Shield or because it really is not compatible?

I would love to use it on my Shield!!

wolpi commented 2 years ago

So far I have no idea how an app could be made visible for shield

PietroPizzi69 commented 2 years ago

I'm no Android DEV but maybe this helps!? https://youtu.be/Gid6c_-80EM

And for comparison, it is possible to install SimpleSSHD on my Shield: https://play.google.com/store/apps/details?id=org.galexander.sshd It is implemented since v23 (2019-09-21): http://www.galexander.org/software/simplesshd/ This App is OpenSource, so you can check it out: http://galexander.org/git/simplesshd.git Or kindly ask greg@galexander.org about a hint.

Hope this helps!

wolpi commented 2 years ago

I'm going to have a look at these links ...

wolpi commented 2 years ago

To publish for nvidia shield on google play means to publish for android tv. An app must provide additional screenshots and a banner for that. And google has an own policiy for andriod tv. Apps which like to publish are reviewed according to this policy. This app is under review now.

PietroPizzi69 commented 2 years ago

Nice :)! I obviously hope that it succeeds. Great that you looked into this!! If it goes through the process I will try it as soon as I have the time :)!

Pentaphon commented 2 years ago

This app is under review now.

You're going to make lots of Android TV users very happy with this change. People have been looking for an open source app that opens a simple server to easily transfer files to and from their TV device.

wolpi commented 1 year ago

As you can see by linked commit, there are some more changes to address Google's feedback. Not sure if they are happy with that.

wolpi commented 1 year ago

With Version 6.16 Google has same review results as before. Both issues are already adressed. It is unclear what Google checks.

grafik

wolpi commented 1 year ago

The DPad Issue might be solved with introduction of Tabs as in #281

Pentaphon commented 1 year ago

The DPad Issue might be solved with introduction of Tabs as in #281

Thank you. A lot of people will find this useful. Have you created a banner (basically a tv-shaped icon) for the Android TV launcher like the ones you see on the screenshot of the Android TV Play Store below?

play

It should be fairly easy. just make a blue banner using the color of the original icon, write "Primitive FTPd" on it the same way you did in this icon and add the little purple icon inside the full size banner somewhere where it looks good. It should be enough and simple to look at.

unnamed

wolpi commented 1 year ago

Yes, such a banner is present, as can be seen in linked commits. Obviiously Google is not happy with it :sob:

mylove90 commented 1 year ago

Thanks for all your hard efforts....i have an old tv with Kitkat 4.4...when i open the app on it there is no buttons...will that be resolved with the release of the tv app ?

wolpi commented 1 year ago

Android TV uses another launcher Activity configured with another category in Manifest. It's called Leanback. Your android version obviously does not use the Leanback-Activity but the other Activity intended for phones and tablets. You can search for ways to choose another Activity when launching the app (and then choose leanback).

will that be resolved with the release of the tv app

No, that will just make the app availble on Google Play for Android TV.

wolpi commented 11 months ago

Added Milestone 7.0 as changes in that version affect this issue, let's see how google review sees that.

wolpi commented 11 months ago

New review results are present.

Funny that they don't complain about banner anymore but still about DPad. There has been no change regarding banner but with new tab-ui DPad has changed heavily. This review result is completley unexpected.

grafik

Pentaphon commented 11 months ago

Anything you can change on the UI to make it more D-Pad friendly?

wolpi commented 11 months ago

There is D-Pad support. No idea why Google rejects this.

Pentaphon commented 11 months ago

There is D-Pad support. No idea why Google rejects this.

I just sideloaded primitiveFTPd-7.0-googleplay.apk on my Google TV device and while it does switch tabs when you select and press them with the remote's D-Pad, when I go to the "start server" button, it doesn't seem to actually press when using the remote. There's no way to start the server. I just keep pressing "start server" and the server doesn't start. Perhaps they found that this functionality is missing. Have you tested the app on an Android/Google TV device yourself with a remote?

Also, the banner seems unfinished. It is black and the icon is off to the left side with the name of the app in the center. I think it needs to be white instead of black, as well.

wolpi commented 11 months ago

I'm testing it in simulator with keyboard. It works there. Good to know that there are issues with real hardware. I'll have a look. As soon as I find time.

r3a1d3a1 commented 8 months ago

I've sideloaded this on my Shield. I've to use a mouse to "Start Server" as the D-Pad can't navigate to it. Furthermore, for better D-pad compatibility, it's best for the buttons-layout to be more hierarchical than flat and be given proper priority in navigation. (e.g. making Start-Server number 1)

wolpi commented 8 months ago

Yes, that are required changes for this topic. You can wait until I find time for them or provide a PR :wink:

wolpi commented 8 months ago

According to docs D-Pad should behave the same as keyboard:

So far I've been happy with default navigation order. But yes, that behaves weird in some cases. Therefore i did some adjustments.

Next issue is, that in TV mode, some elements don't show that they have focus. Thus you cannot see where your cursor is.

wolpi commented 7 months ago

I think with latest changes it is worth another try.

Pentaphon commented 7 months ago

Thank you for keeping up with this Wolpi, TV devices really benefit the most from an open source FTP server so we can send files to them easily.

wolpi commented 7 months ago

Version 7.1 has again been rejected. This time for another reason. This version contained a change to improve situation with copy dialog (receive shared files) and screen orientation changes. It used a simple approach to just declare a specific orientation in manifest. That is forbidden for Android TV. Thus it had to be changed, see commit above.

PietroPizzi69 commented 7 months ago

Seams like to be a hard time to be an Android TV developer :(.

wolpi commented 2 months ago

Google seems to have accepted it in meantime, without sending notification. Can you confirm?