wolpi / prim-ftpd

FTP server app for android
Other
580 stars 78 forks source link

Udate Readme and UI #348

Closed lmagyar closed 1 week ago

lmagyar commented 1 month ago

A bit reformatted the Readme. :)

And added info about permanent SAF access.

Though it is strange, that I don't remember that I had to do this trick for the other apps. I've checked the source of Markor, and couldn't figure out the root cause of the difference (note: I'm a total newbie in case of Android dev).

wolpi commented 3 weeks ago

Oh no! The new text-key got copied to many (all?) translation files. The intention was that it would not be present there and people know they have to add it.

lmagyar commented 3 weeks ago

OK, please tell me what to do, I really don't know how to manage translations with Weblate.

So, I revert all the renames in the translation files, except the original english, and leave this as is? What will happen when there is no V2 string in an non-english language?

    <TextView
        android:id="@+id/safExplain"
        android:layout_width="fill_parent"
        android:layout_height="wrap_content"
        android:gravity="center_horizontal"
        android:text="@string/safExplainV2"
        />
wolpi commented 3 weeks ago

So, I revert all the renames in the translation files, except the original english, and leave this as is?

Yes, exactly.

What will happen when there is no V2 string in an non-english language?

They will fallback to english. That is why the english file lives in folder "values" (without language code). That is the behavior I want to have. Old tanslation shall not be shown anymore. If some language does not have the new text it shall show the english one. We cannot rely on translators providing a new text.

wolpi commented 3 weeks ago

I merged recent weblate changes today, that leads to conflict in this PR. Probably the conflict would just be resolved with removing the new text-key from all the translation files.

lmagyar commented 3 weeks ago

They will fallback to english. That is why the english file lives in folder "values" (without language code). That is the behavior I want to have. Old tanslation shall not be shown anymore. If some language does not have the new text it shall show the english one. We cannot rely on translators providing a new text.

Oh, now I understand! :) Clever trick! Better to show an updated english, than an old translation!

lmagyar commented 3 weeks ago

It's done. Tested, Hungarian version shows the new English text. 👍

I will add more Hungarian translations, but that is 10 times more tiring, than writing code. :D

wolpi commented 1 week ago

Thanks :tada: