search

wolpi / prim-ftpd

FTP server app for android
Other
580 stars 78 forks source link

Bugfix to handle unsigned int8 message types that are >127 #349

Open lmagyar opened 1 month ago

lmagyar commented 1 month ago

It is needed for the extended commands. See the next PR #350

wolpi commented 1 month ago

Well, usually I avoid to do changes in the copied code-base of libraries, but in this case it makes sense

lmagyar commented 1 month ago

Without this we receive "Command -56 is unsupported or not implemented" errors.

It's a bug, but they never noticed it, because they didn't use any extended command. The hash extended command (#350) can be seen as a backport of this functionality. Like in the Python paramiko library: https://github.com/paramiko/paramiko/blob/main/paramiko/sftp_server.py#L291

lmagyar commented 3 days ago

(just rebased it to latest master)