search

wolray / symbol-overlay

Highlight symbols with keymap-enabled overlays
346 stars 42 forks source link

Align Package-Version header with git tag in new release #113

Closed kickingvegas closed 2 months ago

kickingvegas commented 2 months ago

Request for an updated release that aligns the Package-Version header value with the git tag.

kickingvegas commented 2 months ago

Looks like this just got fixed with https://github.com/wolray/symbol-overlay/pull/112

kickingvegas commented 2 months ago

Actually, re-opening because #112 now has introduced condition where the git tag 4.2 is not aligned with the the value of ~Package-Requires~ Package-Version.

purcell commented 2 months ago

now has introduced condition where the git tag 4.2 is not aligned with the the value of Package-Requires.

Huh, there's now an installable v4.2 of the package, so I'm not sure what issue you're encountering.

kickingvegas commented 2 months ago

@purcell But was the tag moved? If a user checks out the tag 4.2, they will get a version of the code where the ~Package-Requires~ Package-Version header is set to 4.1.

purcell commented 2 months ago

You mean Package-Version and not Package-Requires, I think? If so, that's not a big deal and shouldn't stop anyone from using the package. I'm not in favour of moving tags. When we cut a 4.3, we can make sure things line up better.

kickingvegas commented 2 months ago

@purcell my bad, yes Package-Version. Will amend. To clarify, I'm not recommending moving a tag. I would of expected that the PR #112 would of created a new tag (ideally 4.3 but that's foregone).

purcell commented 2 months ago

Cool, yes. Well, I've just bumped the version to 4.3 and tagged it, so everything should line up now.