search

wolray / symbol-overlay

Highlight symbols with keymap-enabled overlays
346 stars 42 forks source link

add faces, replace color logic with face logic #16

Closed emacswatcher closed 6 years ago

emacswatcher commented 6 years ago

  1. Set up customizeable faces

  2. Change the internal overlay creation to use faces

  3. Change the primary face attribute to ":box" from ":background" by default because :background is used by other packages (and region).

The first two are pretty seamless. The last one might be a step too far since it changes your look and feel but using :background was stopping me from using the package. If you'd like me to change it back to using :background by default, I'd be happy to.

Cheers.

wolray commented 6 years ago

merged, thanks