search

wolray / symbol-overlay

Highlight symbols with keymap-enabled overlays
346 stars 42 forks source link

[Request] highlight TODO #39

Closed seagle0128 closed 5 years ago

seagle0128 commented 5 years ago

I am happy with symbol-overlay and hl-todo. But hl-todo uses font-lock while not overlay, so it is slow. Can you please integrate these functionalities into symbol-overlay? I think only highlight the keywords in comments for prog-mode, and all for text-mode. Thank you!

purcell commented 5 years ago

This is out of scope for symbol-overlay, I think.

A better approach would be to tackle any slowness in hl-todo: font-lock should not normally be slow.

Using overlays would not be ideal for this problem because they must be programmatically updated every time the text in the buffer changes (just in case new keywords need to be highlighted), and this can also get very slow.

seagle0128 commented 5 years ago

Okay. It makes sense.