search

wolray / symbol-overlay

Highlight symbols with keymap-enabled overlays
346 stars 42 forks source link

Request: support customize number of overlay symbols instead of by default 8 overlay symbols #50

Closed snowman closed 5 years ago

purcell commented 5 years ago

Could you provide more information, please? Are you talking about more or fewer symbols? How would this work, and in what way is the current scheme not working for you?

snowman commented 5 years ago

Expect

  1. Are you talking about more or fewer symbols? Yes, I need more overlayed symbols.

  2. How would this work, and in what way is the current scheme not working for you? The current scheme is supporting overlay 8 symbols, but when I overlay a different symbol (the 9th symbol), the 1st overlayed symbol's color was removed.

  3. Expect Instead of overlay 8 symbols at the same time, remove this limit or add a customizable variable which the value by default is 8.

Example

Current overlayed

Screen Shot 2019-06-17 at 10 50 29 AM

After overlay the 9th symbols, the 1st symbol color was removed

Screen Shot 2019-06-17 at 10 51 27 AM
purcell commented 5 years ago

Great, thanks for the explanation!

purcell commented 5 years ago

I took a look at the code, and it appears that you would already be able to define additional faces and add them to symbol-overlay-faces to get the effect you want. Have you tried doing that? I feel like the built-in behaviour is a good default for most people, because large numbers of different colour overlays would soon become confusing.

snowman commented 5 years ago

thanks, you are right, I should first view the code... sorry to wasting your time

purcell commented 5 years ago

No worries at all.