search

wolray / symbol-overlay

Highlight symbols with keymap-enabled overlays
346 stars 42 forks source link

Overlay conflicts with eglot #82

Open hmelman opened 2 years ago

hmelman commented 2 years ago

I'm using (trying out) eglot with python-mode and it highlights the symbol-at-point with an overlay. I used symbol-overlay-put and other occurrences of the symbol highlighted (more clearly), but the keymap symbol-overlay installs didn't work. If I typed n the character was just inserted (eglot's overlay had a modification-hooks property if that matters), it didn't run symbol-overlay-jump-next.

I assumed it was because of conflicting overlays and added a 'priority 100 to the symbol-overlay overlay and it worked great. I don't know as there's a good solution (there was also a flymake overlay at point) but I think it would help if symbol-overlay included a priority in the overlays it uses and gives the user a symbol-overlay-priority user option to customize. That way we could resolve whatever conflicts we come across.

uqix commented 1 year ago

@hmelman found any workaround? this's kind of annoying.

purcell commented 1 year ago

I think it would help if symbol-overlay included a priority in the overlays it uses and gives the user a symbol-overlay-priority user option to customize.

I pushed a quick change to add this. 🤝

TxGVNN commented 1 year ago

Perfect! This feature has changed my life. :laughing: 

(setq symbol-overlay-priority 100)
hmelman commented 1 year ago

It's working well for me too.