Dialog and bottom sheet min height is not respected to modal constraints. We added this test case to playground app.
The root cause is that the modal content constraints are calculated without consideration of the available space and it is independent of the modal constraints. When the min height is more than the content height, we currently don't fill the space to min height. It could be added as a feature in later updates, but adding this feature now will complicate the internal implementation. We can address this issue when we use the page as widget.
Before
After
Related Issues
Issue #259
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.
[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes tests for all changed/updated/fixed behaviors.
[ ] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] The package compiles with the minimum Flutter version stated in the pubspec.yaml
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Description
Dialog and bottom sheet min height is not respected to modal constraints. We added this test case to playground app.
The root cause is that the modal content constraints are calculated without consideration of the available space and it is independent of the modal constraints. When the min height is more than the content height, we currently don't fill the space to min height. It could be added as a feature in later updates, but adding this feature now will complicate the internal implementation. We can address this issue when we use the page as widget.
Related Issues
Issue #259
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?