woltapp / wolt_modal_sheet

This package provides a responsive modal with multiple pages, motion animation for page transitions, and scrollable content within each page.
MIT License
511 stars 64 forks source link

Fix: Dialog and bottom sheet minimum height is not respected to modal content min height #260

Closed ulusoyca closed 4 months ago

ulusoyca commented 4 months ago

Description

Dialog and bottom sheet min height is not respected to modal constraints. We added this test case to playground app.

The root cause is that the modal content constraints are calculated without consideration of the available space and it is independent of the modal constraints. When the min height is more than the content height, we currently don't fill the space to min height. It could be added as a feature in later updates, but adding this feature now will complicate the internal implementation. We can address this issue when we use the page as widget.

Before After

Related Issues

Issue #259

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit d2bf505):

(expires Mon, 15 Jul 2024 13:15:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 00f7f56c8a4ce5693de819a908406c0fc6411226