ThisPR introduces support for both Left-to-Right (LTR) and Right-to-Left (RTL) text directions in the slide animation logic for modal sheet page transitions. The mainContentSlidePosition method is updated to handle different slide directions based on a new isLTR parameter.
Changes
Calculated directionMultiplier based on isLTR and isForwardMove to correctly adjust the animation direction.
For LTR (isLTR = true), the multiplier is 1 for forward moves and -1 for backward moves.
For RTL (isLTR = false), the multiplier is -1 for forward moves and 1 for backward moves.
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.
[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes tests for all changed/updated/fixed behaviors.
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] The package compiles with the minimum Flutter version stated in the pubspec.yaml
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Summary
ThisPR introduces support for both Left-to-Right (LTR) and Right-to-Left (RTL) text directions in the slide animation logic for modal sheet page transitions. The mainContentSlidePosition method is updated to handle different slide directions based on a new
isLTR
parameter.Changes
Calculated directionMultiplier based on
isLTR
andisForwardMove
to correctly adjust the animation direction. For LTR (isLTR = true), the multiplier is 1 for forward moves and -1 for backward moves. For RTL (isLTR = false), the multiplier is -1 for forward moves and 1 for backward moves.Related Issues
Fixes https://github.com/woltapp/wolt_modal_sheet/issues/266
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
https://github.com/user-attachments/assets/0b89e936-b90e-469e-907e-228e4c357607