search

woltapp / wolt_modal_sheet

This package provides a responsive modal with multiple pages, motion animation for page transitions, and scrollable content within each page.
MIT License
511 stars 64 forks source link

Switch flutter_keyboard_visibility with flutter native check #302

Closed moshe5745 closed 3 months ago

moshe5745 commented 3 months ago

Description

Deleting the flutter_keyboard_visibility package and replacing it with native flutter logic.

Related Issues

(https://github.com/woltapp/wolt_modal_sheet/issues/210)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Failing tests - Dont have time to figure out whats going on. Maybe someone will help me.

Breaking Change

No

ulusoyca commented 3 months ago

Thanks @moshe5745 It looks like your solution works and it is super exciting!

However I see a delay with the top bar visibility adjustment as I recorded in this video. Do you have time to check this? I will also check when I have time.

https://github.com/user-attachments/assets/71b7672c-dcab-4cd5-81bf-996164b7496d

moshe5745 commented 3 months ago

I will check it Maybe the debounce is not the right approach here, and throttle is the right one.

ulusoyca commented 3 months ago

I will check it Maybe the debounce is not the right approach here, and throttle is the right one.

Great. you can test with the playground app

ulusoyca commented 3 months ago

@moshe5745 Can you check my PR: https://github.com/woltapp/wolt_modal_sheet/pull/303

I came up with more modular solution inspired from this PR.