search

woltapp / wolt_modal_sheet

This package provides a responsive modal with multiple pages, motion animation for page transitions, and scrollable content within each page.
MIT License
511 stars 64 forks source link

Some of the tests are failing in Flutter 3.16.0 and newer versions #320

Closed jebstern closed 1 month ago

jebstern commented 2 months ago

Bug report

Describe the bug Just wanted to inform you that some of the tests are failing in Flutter 3.16.0 and newer versions.

Steps to reproduce

Steps to reproduce the behavior:

  1. Use Flutter 3.16.0 or newer version.
  2. Run tests.
  3. Some of the tests fail.

Expected behavior

Tests should all pass.

Additional context

In Flutter 3.16.0, the ThemeData.useMaterial3 flag is true by default, which seems to possible be the root cause.

By changing the useMaterial3 boolean, tests would fail when true & succeed when false

image _wolt_modalsheet.dart

ulusoyca commented 2 months ago

Thanks for the report! Do you mind fixing the tests with a PR?

ulusoyca commented 2 months ago

Oh actually, this PR by @mhadaily is fixing it: https://github.com/woltapp/wolt_modal_sheet/pull/315

I guess :)

jebstern commented 2 months ago

Sorry for late reply! Okay, no need then 😄