search

woltapp / wolt_modal_sheet

This package provides a responsive modal with multiple pages, motion animation for page transitions, and scrollable content within each page.
MIT License
499 stars 65 forks source link

The content shines through below the `stickyActionBar` during transition #321

Open ciriousjoker opened 2 months ago

ciriousjoker commented 2 months ago

Bug report

Describe the bug Because the stickyActionBar is crossfaded, the content shines through below it, just watch the video.

https://github.com/user-attachments/assets/aefb856a-06ac-4c98-a22c-f66f866bc1ee

Steps to reproduce

Steps to reproduce the behavior:

  1. Add a stickyActionBar with a solid color background
  2. Do a multi step modal and transition to the next screen

Expected behavior

If the stickyActionBar has a solid background, it should be respected and the transition should be "clipped" because of it.

Additional context

Why is the stickyActionBar being crossfaded? Wouldn't it be enough to keep the old stickyActionBar fully in place, fade the new stickyActionBar in and remove the old stickyActionBar afterwards? That way the transparency wouldn't shine through.

ulusoyca commented 2 months ago

Can you play with these values?

https://github.com/woltapp/wolt_modal_sheet/blob/65721b37fcdc25a05ceb5b2f175ec29109672ec2/lib/src/theme/wolt_modal_sheet_animation_style.dart#L167

https://github.com/woltapp/wolt_modal_sheet/blob/65721b37fcdc25a05ceb5b2f175ec29109672ec2/lib/src/theme/wolt_modal_sheet_animation_style.dart#L171

https://github.com/woltapp/wolt_modal_sheet?tab=readme-ov-file#example-configuration